Re: Review Request 52548: LENS-1345: Deadlock in jdbc query status update

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52548/#review151758
---


Fix it, then Ship it!





lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
(line 941)


Should be not failed?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 580)


null check should not be required as it is in constructor.


- Amareshwari Sriramadasu


On Oct. 6, 2016, 1:54 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52548/
> ---
> 
> (Updated Oct. 6, 2016, 1:54 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1345
> https://issues.apache.org/jira/browse/LENS-1345
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads.
> 
> 
> Diffs
> -
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  e4984798751d012f0a9d01980df833c206155546 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
>  033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  87d7cb0d5036bd0de4361cc146404a7fee478bac 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> 57786e6cad53651b1a3256c0a76437c6e43c2c77 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 3f71aef9ca180d834538604925c71d1d87be8e26 
> 
> Diff: https://reviews.apache.org/r/52548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552092#comment-15552092
 ] 

Hadoop QA commented on LENS-1345:
-

Applied patch: 
[LENS-1345.02.patch|https://issues.apache.org/jira/secure/attachment/12831959/LENS-1345.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1002/

> Deadlock in jdbc query status update
> 
>
> Key: LENS-1345
> URL: https://issues.apache.org/jira/browse/LENS-1345
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1345.02.patch
>
>
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1345) Deadlock in jdbc query status update

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1345:
---
Status: Patch Available  (was: In Progress)

> Deadlock in jdbc query status update
> 
>
> Key: LENS-1345
> URL: https://issues.apache.org/jira/browse/LENS-1345
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1345.02.patch
>
>
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1345) Deadlock in jdbc query status update

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1345:
---
Attachment: LENS-1345.02.patch

> Deadlock in jdbc query status update
> 
>
> Key: LENS-1345
> URL: https://issues.apache.org/jira/browse/LENS-1345
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1345.02.patch
>
>
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1345) Deadlock in jdbc query status update

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551991#comment-15551991
 ] 

Rajat Khandelwal commented on LENS-1345:


Taking patch from reviewboard and attaching

> Deadlock in jdbc query status update
> 
>
> Key: LENS-1345
> URL: https://issues.apache.org/jira/browse/LENS-1345
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1345.02.patch
>
>
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52548: LENS-1345: Deadlock in jdbc query status update

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52548/
---

(Updated Oct. 6, 2016, 7:24 p.m.)


Review request for lens.


Bugs: LENS-1345
https://issues.apache.org/jira/browse/LENS-1345


Repository: lens


Description
---

JDBC query is launched in a thread. On query finish, the thread calls back the 
query service to update status, which creates a FinishedQuery instance. In the 
constructor, FinishedQuery is fetching result from the jdbc driver, which waits 
on the original thread to complete. Basically the thread is waiting for itself. 

In the callback, query context is acquired by the thread, and can't be acquired 
again. Which means that get calls for this query won't return and will stay 
blocked. This can end up blocking all the grizzly threads.


Diffs (updated)
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 e4984798751d012f0a9d01980df833c206155546 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 87d7cb0d5036bd0de4361cc146404a7fee478bac 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
57786e6cad53651b1a3256c0a76437c6e43c2c77 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
3f71aef9ca180d834538604925c71d1d87be8e26 

Diff: https://reviews.apache.org/r/52548/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-743) Query failure retries for transient errors

[Hadoop QA (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hadoop QA updated LENS-743:
---
Status: Open  (was: Patch Available)

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
> Attachments: LENS-743.09.patch
>
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-743) Query failure retries for transient errors

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551859#comment-15551859
 ] 

Hadoop QA commented on LENS-743:


Patch does not apply. Build job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1001/

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
> Attachments: LENS-743.09.patch
>
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551829#comment-15551829
 ] 

Hadoop QA commented on LENS-1287:
-

Applied patch: 
[LENS-1287.07.patch|https://issues.apache.org/jira/secure/attachment/12831710/LENS-1287.07.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1000/

> Create command in cli to create schema taking parent directory where schema 
> is stored
> -
>
> Key: LENS-1287
> URL: https://issues.apache.org/jira/browse/LENS-1287
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1287.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-743) Query failure retries for transient errors

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-743:
--
Status: Patch Available  (was: In Progress)

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
> Attachments: LENS-743.09.patch
>
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-743) Query failure retries for transient errors

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-743:
--
Attachment: LENS-743.09.patch

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
> Attachments: LENS-743.09.patch
>
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-743) Query failure retries for transient errors

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551818#comment-15551818
 ] 

Rajat Khandelwal commented on LENS-743:
---

Taking patch from reviewboard and attaching

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: gsoc2016, java
> Attachments: LENS-743.09.patch
>
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52088/
---

(Updated Oct. 6, 2016, 5:59 p.m.)


Review request for lens.


Bugs: LENS-743
https://issues.apache.org/jira/browse/LENS-743


Repository: lens


Description
---

There have to be retries for query failures for transient errors like network 
errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). 
Retries should be available for each phase - submission, execution, updating 
status, fetching results and formatting.

Right now, any such failure results in marking query as failed.


Diffs (updated)
-

  checkstyle/src/main/resources/checkstyle.xml 
17e55ea1071c06c73e8bf387cd69acca83bc 
  lens-api/src/main/java/org/apache/lens/api/query/FailedAttempt.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java 
7d079a9ed99e3d4940d5f26370547683a6bba465 
  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
daedbf9ea387cbde3ef39363c2beef3f96725223 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 
04d9ad6dee942c705b0cdf071f49f1305696da65 
  lens-api/src/test/resources/toString/org.apache.lens.api.query.LensQuery.xml 
a681bca7fd6e46fe992901e04e025a8a3106 
  
lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryStatus.xml 
70f9c932efc090095273566eaa52d380a2f23842 
  lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 
fceabeae9217676774a6978212cbc9ee9ca120f7 
  lens-driver-es/src/test/resources/hive-site.xml 
e49c876289d5352203d2523ddb9134d745c197e5 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
0d8810f6b7dfd9fb0173a4be6966f1a561107066 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
daf01ac64616da72ee55c00f71c2c0aa33651ee4 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 1acbb13c3a24c0e7b41d799db0d307c5acfa8c6b 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
 3c34eb191966dff3ac3032eb79282336b5c6789b 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java
 82b56470e2de09f7c41d1226ea59cffdd8d26a26 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 
  
lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java
 d80fba9aee91130b69a2a511d7f157c01a261ac4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8cf617b7181b9a305ea2c68f68c610f823ee75d7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java
 17bfba02244bca7141268ed12e4a41400e2bec82 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FailureContext.java
 70a34b0c0517ed3b7af46120906fb77ae57870ac 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java
 e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/OperationRetryHandlerFactory.java
 88fbe43318315394873cabb9f5dd39f09f6c47f4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 e4984798751d012f0a9d01980df833c206155546 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
e472de0a452ffbbcb217503c260aa26fe7f6ed99 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 b58fcf964cedb8dc302099ae9c806b06acafa2d3 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/PriorityChange.java
 eaf3fee953e1efbcf151fc844a9441b74b84cc3e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAccepted.java
 8980b619c9feb86be326bf799fecc35c1579c763 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryCancelled.java
 a473a47606df84e2b5b204478ad63e63e69b0c23 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryClosed.java 
3837087db6e51c1606573511bfc02b6108d1ef3d 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b584c6a6d414a6f0dac509e67c8944dbd2373325 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java 
e80da6d2a417e1274fb186153ec01615c2da565b 
  

Re: Review Request 52548: LENS-1345: Deadlock in jdbc query status update

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52548/#review151642
---




lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 603)


This should be part of construction time as it is required to be partially 
fetched in some cases.



lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
(line 1435)


I feel we should write a better test which reproduces the issue clearly.


- Amareshwari Sriramadasu


On Oct. 5, 2016, 7:35 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52548/
> ---
> 
> (Updated Oct. 5, 2016, 7:35 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1345
> https://issues.apache.org/jira/browse/LENS-1345
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> JDBC query is launched in a thread. On query finish, the thread calls back 
> the query service to update status, which creates a FinishedQuery instance. 
> In the constructor, FinishedQuery is fetching result from the jdbc driver, 
> which waits on the original thread to complete. Basically the thread is 
> waiting for itself. 
> 
> In the callback, query context is acquired by the thread, and can't be 
> acquired again. Which means that get calls for this query won't return and 
> will stay blocked. This can end up blocking all the grizzly threads.
> 
> 
> Diffs
> -
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  87d7cb0d5036bd0de4361cc146404a7fee478bac 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 3f71aef9ca180d834538604925c71d1d87be8e26 
> 
> Diff: https://reviews.apache.org/r/52548/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1333) Add data completeness checker

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551687#comment-15551687
 ] 

Hadoop QA commented on LENS-1333:
-

Applied patch: 
[LENS-1333-v1.patch|https://issues.apache.org/jira/secure/attachment/12831935/LENS-1333-v1.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/999/

> Add data completeness checker
> -
>
> Key: LENS-1333
> URL: https://issues.apache.org/jira/browse/LENS-1333
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Narayan Periwal
> Attachments: LENS-1333-v1.patch
>
>
> Though lens has partition registration being done whenever data is available, 
> there is no guarantee the partition registered is complete. There can be 
> different ways to know if the data is complete for partition. One option 
> could be to have a partition property saying whether it is complete or not. 
> Other could be to do a http call to another hosted service and more.
> Proposal here is to add an interface for DataCompletenessChecker and do the 
> check while resolving partitions.
> Here are some of the capabilities we would like to add in Lens :
> # Lens will check partition existence first, if it exists, then check the 
> completeness percentage. If the completeness percentage is less than a 
> configured threshold (default should be 98, 99 or even 100), Lens will fail 
> the query.
> # Lens's accept query on partial data will accept on incomplete data as well.
> # Lens will also option to override the completeness percentage threshold 
> value at query level
> # Lens will still have look ahead capability of daily being incomplete, then 
> it will union with hourly. 
> # If same measure is there in two different facts , Lens will we pick the one 
> with higher availability.
> # In case of completeness percentage threshold missed, Lens will respond back 
> with available percentage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1340) Adding API for data completeness checker

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551655#comment-15551655
 ] 

Hadoop QA commented on LENS-1340:
-

Applied patch: 
[LENS-1340-v2.patch|https://issues.apache.org/jira/secure/attachment/12831495/LENS-1340-v2.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/998/

> Adding API for data completeness checker
> 
>
> Key: LENS-1340
> URL: https://issues.apache.org/jira/browse/LENS-1340
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Fix For: 2.7
>
> Attachments: LENS-1340-v2.patch, LENS-1340.patch
>
>
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1285) Adding unit tests for scheduler API

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551636#comment-15551636
 ] 

Hadoop QA commented on LENS-1285:
-

Applied patch: 
[0001-Api-tests.patch|https://issues.apache.org/jira/secure/attachment/12831914/0001-Api-tests.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/996/

> Adding unit tests for scheduler API
> ---
>
> Key: LENS-1285
> URL: https://issues.apache.org/jira/browse/LENS-1285
> Project: Apache Lens
>  Issue Type: Test
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Api-tests.patch, 0001-Resource-tests.patch, 
> Scheduler-API-tests.patch, Scheduler-API-tests.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551626#comment-15551626
 ] 

Hadoop QA commented on LENS-1287:
-

Applied patch: 
[LENS-1287.07.patch|https://issues.apache.org/jira/secure/attachment/12831710/LENS-1287.07.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/997/

> Create command in cli to create schema taking parent directory where schema 
> is stored
> -
>
> Key: LENS-1287
> URL: https://issues.apache.org/jira/browse/LENS-1287
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1287.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52381: LENS-1273 : Resolve issues with case when aggregate expressions with dim-attributes conditions

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52381/#review151478
---


Fix it, then Ship it!




Minor comments.


lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
(line 345)


Can be made static



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
(line 744)


Can we add null check on `colSet` like the previous function?



lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java (line 
221)


isn't `alias!=null` always true inside this block?



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java (lines 
158 - 161)


Can we change names of the `getExpression` methods? Two different functions 
with a generic name seems a bit confusing.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
(line 90)


Can we also add assert on the column absent from all facts?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
(line 744)


Is join happening on dim22 also?


- Rajat Khandelwal


On Sept. 29, 2016, 3:19 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52381/
> ---
> 
> (Updated Sept. 29, 2016, 3:19 p.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Bugs: LENS-1273
> https://issues.apache.org/jira/browse/LENS-1273
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The problem exists with case when aggregate expressions in current code 
> because cube query writing gets all columns queried and checks availability 
> of those columns in eligible facts.
> 
> The fix is to make the checks happen on each select phrase to be separate.
> 
> Changes include :
> - Added QueriedPhraseContext to hold the different queried phrases in all 
> clauses
> - Updated candidate pruning to happen for columns in QueriedPhraseContext 
> instead of all columns queried 
> - Removal of a lot of book keeping done withrespect to columns queried or 
> expressions queried
> - Added aggregate as a field in QueriedPhraseContext and updated 
> GroupbyResolver to make use of the same.
> - Also moved alias for select phrase to SelectPhraseContext and updated its 
> in all relavant places.
> 
> Planning to do some more clean up in a follow up jira wrt 
> denormalizationResovler and optional dimension tables.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 292868a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> 5b48ca4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 01265a5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  83e5088 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> 2db5dd1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 63ec8b2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  ab1710d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 5adea6c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 8beeb9d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
> 7fbcd7e 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SelectPhraseContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> ca176ee 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedColumns.java 
> b65ac26 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/TrackQueriedCubeFields.java
>  PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/TracksQueriedColumns.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> f7f8af2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 
> 35234a1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 6fb027a 
> 
> Diff: https://reviews.apache.org/r/52381/diff/
> 
> 
> Testing
> ---
> 
> All cube tests pass.
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

[jira] [Updated] (LENS-1333) Add data completeness checker

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1333:
--
Attachment: LENS-1333-v1.patch

> Add data completeness checker
> -
>
> Key: LENS-1333
> URL: https://issues.apache.org/jira/browse/LENS-1333
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Narayan Periwal
> Attachments: LENS-1333-v1.patch
>
>
> Though lens has partition registration being done whenever data is available, 
> there is no guarantee the partition registered is complete. There can be 
> different ways to know if the data is complete for partition. One option 
> could be to have a partition property saying whether it is complete or not. 
> Other could be to do a http call to another hosted service and more.
> Proposal here is to add an interface for DataCompletenessChecker and do the 
> check while resolving partitions.
> Here are some of the capabilities we would like to add in Lens :
> # Lens will check partition existence first, if it exists, then check the 
> completeness percentage. If the completeness percentage is less than a 
> configured threshold (default should be 98, 99 or even 100), Lens will fail 
> the query.
> # Lens's accept query on partial data will accept on incomplete data as well.
> # Lens will also option to override the completeness percentage threshold 
> value at query level
> # Lens will still have look ahead capability of daily being incomplete, then 
> it will union with hourly. 
> # If same measure is there in two different facts , Lens will we pick the one 
> with higher availability.
> # In case of completeness percentage threshold missed, Lens will respond back 
> with available percentage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1333) Add data completeness checker

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1333:
--
Status: Patch Available  (was: In Progress)

> Add data completeness checker
> -
>
> Key: LENS-1333
> URL: https://issues.apache.org/jira/browse/LENS-1333
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Narayan Periwal
> Attachments: LENS-1333-v1.patch
>
>
> Though lens has partition registration being done whenever data is available, 
> there is no guarantee the partition registered is complete. There can be 
> different ways to know if the data is complete for partition. One option 
> could be to have a partition property saying whether it is complete or not. 
> Other could be to do a http call to another hosted service and more.
> Proposal here is to add an interface for DataCompletenessChecker and do the 
> check while resolving partitions.
> Here are some of the capabilities we would like to add in Lens :
> # Lens will check partition existence first, if it exists, then check the 
> completeness percentage. If the completeness percentage is less than a 
> configured threshold (default should be 98, 99 or even 100), Lens will fail 
> the query.
> # Lens's accept query on partial data will accept on incomplete data as well.
> # Lens will also option to override the completeness percentage threshold 
> value at query level
> # Lens will still have look ahead capability of daily being incomplete, then 
> it will union with hourly. 
> # If same measure is there in two different facts , Lens will we pick the one 
> with higher availability.
> # In case of completeness percentage threshold missed, Lens will respond back 
> with available percentage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52514: Add data completeness checker

[Narayan Periwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52514/
---

(Updated Oct. 6, 2016, 10:45 a.m.)


Review request for lens.


Bugs: LENS-1333
https://issues.apache.org/jira/browse/LENS-1333


Repository: lens


Description
---

Though lens has partition registration being done whenever data is available, 
there is no guarantee the partition registered is complete. There can be 
different ways to know if the data is complete for partition. One option could 
be to have a partition property saying whether it is complete or not. Other 
could be to do a http call to another hosted service and more.

Proposal here is to add an interface for DataCompletenessChecker and do the 
check while resolving partitions.

Here are some of the capabilities we would like to add in Lens :
# Lens will check partition existence first, if it exists, then check the 
completeness percentage. If the completeness percentage is less than a 
configured threshold (default should be 98, 99 or even 100), Lens will fail the 
query.
# Lens's accept query on partial data will accept on incomplete data as well.
# Lens will also option to override the completeness percentage threshold value 
at query level
# Lens will still have look ahead capability of daily being incomplete, then it 
will union with hourly. 
# If same measure is there in two different facts , Lens will we pick the one 
with higher availability.
# In case of completeness percentage threshold missed, Lens will respond back 
with available percentage.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
fb958c3 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
4585ef7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 01265a5 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 78fb21d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
49ed5ef 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
13f1aa4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
db26718 
  lens-cube/src/main/resources/olap-query-conf.xml 0c888ca 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f7f8af2 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/DefaultCompletenessChecker.java
 PRE-CREATION 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 7afa32e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
b90d4d3 
  lens-server/src/main/resources/lenssession-default.xml b6bfa2e 

Diff: https://reviews.apache.org/r/52514/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 52514: Add data completeness checker

[Narayan Periwal]

> On Oct. 5, 2016, 6:49 a.m., Amareshwari Sriramadasu wrote:
> > .gitignore, line 40
> > 
> >
> > Can you avoid this change?

I will revert this change.


> On Oct. 5, 2016, 6:49 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java,
> >  line 120
> > 
> >
> > Should be added after MISSING_PARTITIONS.
> > 
> > Also lets change the text to "Data is incomplete. Details : %s"

Done.


On Oct. 5, 2016, 6:49 a.m., Narayan Periwal wrote:
> > Can you add testcases for all capabilities listed in description?

Adding test cases for all the capabilities listed.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52514/#review151465
---


On Oct. 4, 2016, 2:10 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52514/
> ---
> 
> (Updated Oct. 4, 2016, 2:10 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1333
> https://issues.apache.org/jira/browse/LENS-1333
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Though lens has partition registration being done whenever data is available, 
> there is no guarantee the partition registered is complete. There can be 
> different ways to know if the data is complete for partition. One option 
> could be to have a partition property saying whether it is complete or not. 
> Other could be to do a http call to another hosted service and more.
> 
> Proposal here is to add an interface for DataCompletenessChecker and do the 
> check while resolving partitions.
> 
> Here are some of the capabilities we would like to add in Lens :
> # Lens will check partition existence first, if it exists, then check the 
> completeness percentage. If the completeness percentage is less than a 
> configured threshold (default should be 98, 99 or even 100), Lens will fail 
> the query.
> # Lens's accept query on partial data will accept on incomplete data as well.
> # Lens will also option to override the completeness percentage threshold 
> value at query level
> # Lens will still have look ahead capability of daily being incomplete, then 
> it will union with hourly. 
> # If same measure is there in two different facts , Lens will we pick the one 
> with higher availability.
> # In case of completeness percentage threshold missed, Lens will respond back 
> with available percentage.
> 
> 
> Diffs
> -
> 
>   .gitignore aca87dc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> fb958c3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 4585ef7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 01265a5 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  78fb21d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 49ed5ef 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  13f1aa4 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> db26718 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> f7f8af2 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/DefaultCompletenessChecker.java
>  PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  7afa32e 
> 
> Diff: https://reviews.apache.org/r/52514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

[jira] [Commented] (LENS-1340) Adding API for data completeness checker

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551444#comment-15551444
 ] 

Hadoop QA commented on LENS-1340:
-

Applied patch: 
[LENS-1340-v2.patch|https://issues.apache.org/jira/secure/attachment/12831495/LENS-1340-v2.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/995/

> Adding API for data completeness checker
> 
>
> Key: LENS-1340
> URL: https://issues.apache.org/jira/browse/LENS-1340
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Fix For: 2.7
>
> Attachments: LENS-1340-v2.patch, LENS-1340.patch
>
>
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1285) Adding unit tests for scheduler API

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551424#comment-15551424
 ] 

Hadoop QA commented on LENS-1285:
-

Applied patch: 
[0001-Api-tests.patch|https://issues.apache.org/jira/secure/attachment/12831914/0001-Api-tests.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/994/

> Adding unit tests for scheduler API
> ---
>
> Key: LENS-1285
> URL: https://issues.apache.org/jira/browse/LENS-1285
> Project: Apache Lens
>  Issue Type: Test
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Api-tests.patch, 0001-Resource-tests.patch, 
> Scheduler-API-tests.patch, Scheduler-API-tests.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551310#comment-15551310
 ] 

Hadoop QA commented on LENS-1287:
-

Applied patch: 
[LENS-1287.07.patch|https://issues.apache.org/jira/secure/attachment/12831710/LENS-1287.07.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/993/

> Create command in cli to create schema taking parent directory where schema 
> is stored
> -
>
> Key: LENS-1287
> URL: https://issues.apache.org/jira/browse/LENS-1287
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1287.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1340) Adding API for data completeness checker

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1340:
--
Status: Patch Available  (was: In Progress)

> Adding API for data completeness checker
> 
>
> Key: LENS-1340
> URL: https://issues.apache.org/jira/browse/LENS-1340
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Fix For: 2.7
>
> Attachments: LENS-1340-v2.patch, LENS-1340.patch
>
>
> The data completeness API will take the factTag, startDate, endDate and 
> measure's list as input. 
> It will return the completeness percentage for each of the measures for the 
> given factTag and time range.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1343) expression not being propagated to error message in COULD_NOT_PARSE_EXPRESSION error

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551120#comment-15551120
 ] 

Hudson commented on LENS-1343:
--

SUCCESS: Integrated in Jenkins build Lens-Commit #1354 (See 
[https://builds.apache.org/job/Lens-Commit/1354/])
LENS-1343 : Fix expression not being propagated to error message in 
(amareshwari: rev 1bb189b30f99413fffd5ee978b7fbd728a03c268)
* (edit) lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
* (edit) lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java
* (edit) lens-cube/src/test/resources/hive-site.xml


> expression not being propagated to error message in 
> COULD_NOT_PARSE_EXPRESSION error
> 
>
> Key: LENS-1343
> URL: https://issues.apache.org/jira/browse/LENS-1343
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1343.03.patch, LENS-1343.2016-10-03_12:58:34.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1287) Create command in cli to create schema taking parent directory where schema is stored

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551079#comment-15551079
 ] 

Hadoop QA commented on LENS-1287:
-

Applied patch: 
[LENS-1287.07.patch|https://issues.apache.org/jira/secure/attachment/12831710/LENS-1287.07.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/992/

> Create command in cli to create schema taking parent directory where schema 
> is stored
> -
>
> Key: LENS-1287
> URL: https://issues.apache.org/jira/browse/LENS-1287
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1287.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)