[jira] [Updated] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1381:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Changes are committed as part of LENS-1391

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix_1.patch, 
> LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1391:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh] !

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1391.1.patch, LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972528#comment-15972528
 ] 

Hadoop QA commented on LENS-1381:
-

Applied patch: 
[LENS-1381_checkstyle_fix_1.patch|https://issues.apache.org/jira/secure/attachment/12863798/LENS-1381_checkstyle_fix_1.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1254/

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix_1.patch, 
> LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Sushil Mohanty (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1381:
-
Attachment: LENS-1381_checkstyle_fix_1.patch

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix_1.patch, 
> LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972491#comment-15972491
 ] 

Hadoop QA commented on LENS-1391:
-

Applied patch: 
[LENS-1391.1.patch|https://issues.apache.org/jira/secure/attachment/12863787/LENS-1391.1.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1253/

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.1.patch, LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972475#comment-15972475
 ] 

Hadoop QA commented on LENS-1381:
-

Applied patch: 
[LENS-1381_checkstyle_fix.patch|https://issues.apache.org/jira/secure/attachment/12863777/LENS-1381_checkstyle_fix.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1252/

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1391:
--
Attachment: LENS-1391.1.patch

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.1.patch, LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Puneet Gupta (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972412#comment-15972412
 ] 

Puneet Gupta commented on LENS-1391:


[~lavkesh] please fix the checkstyle errors

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1391:
--
Attachment: (was: LENS-1391.patch)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-18 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review172173
---




lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
Line 36 (original), 37 (patched)


Lets avoid this. Whats the purpose of keeping CubeQueryContext in exception 
class?



lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java
Lines 59 (patched)


Can we add javadoc for all default methods added?



lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java
Lines 233 (patched)


Needs better exception message. also these errors will result in 500 
errors, need to be handled well.



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java
Lines 38 (patched)


How is prune cause getting populated?


- Amareshwari Sriramadasu


On April 13, 2017, 9:55 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 13, 2017, 9:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/ds/Tuple2.java PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateSegmentResolver.java
>  PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>

[jira] [Updated] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Sushil Mohanty (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1381:
-
Attachment: LENS-1381_checkstyle_fix.patch

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1381) Support Fact to Fact Union

2017-04-18 Thread Sushil Mohanty (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1381:
-
Status: Patch Available  (was: Reopened)

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1381_4.patch, LENS-1381_checkstyle_fix.patch
>
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1411) Queries not rewritten correctly when aggregate expression used inside "case when..."

2017-04-18 Thread Sushil Mohanty (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1411:
-
Attachment: LENS-1411.patch

Small change, attaching patch directly in the ticket.

> Queries not rewritten correctly when aggregate expression used inside "case 
> when..."
> 
>
> Key: LENS-1411
> URL: https://issues.apache.org/jira/browse/LENS-1411
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1411.patch
>
>
> Found error in rewritten query when aggregate expressions used inside "case 
> when" statement. 
> for eg  : 
> {CODE}
> CASE
> WHEN (sum((db.msr1)) = 0) THEN 0
> ELSE ((sum((db.msr2)) / sum((db.msr1))) * 1000)
> END AS `expr1`
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1411) Queries not rewritten correctly when aggregate expression used inside "case when..."

2017-04-18 Thread Sushil Mohanty (JIRA) 
Sushil Mohanty created LENS-1411:


 Summary: Queries not rewritten correctly when aggregate expression 
used inside "case when..."
 Key: LENS-1411
 URL: https://issues.apache.org/jira/browse/LENS-1411
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Found error in rewritten query when aggregate expressions used inside "case 
when" statement. 
for eg  : 
{CODE}
CASE
WHEN (sum((db.msr1)) = 0) THEN 0
ELSE ((sum((db.msr2)) / sum((db.msr1))) * 1000)
END AS `expr1`
{CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972333#comment-15972333
 ] 

Hadoop QA commented on LENS-1405:
-

Applied patch: 
[lens_latest.patch|https://issues.apache.org/jira/secure/attachment/12863755/lens_latest.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1250/

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: lens_latest.patch, Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58496: Review comments on the MaxCoveringFactResolver

2017-04-18 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58496/#review172174
---


Ship it!




Ship It!

- Puneet Gupta


On April 18, 2017, 6:41 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58496/
> ---
> 
> (Updated April 18, 2017, 6:41 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Comments and cleanup
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d356 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  a9bd164 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  34180d1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> d95cf27 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  064da01 
> 
> 
> Diff: https://reviews.apache.org/r/58496/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-1409) Remove Unknown.log file before lens startup

2017-04-18 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972238#comment-15972238
 ] 

Hudson commented on LENS-1409:
--

FAILURE: Integrated in Jenkins build Lens-Commit #1393 (See 
[https://builds.apache.org/job/Lens-Commit/1393/])
LENS-1409 : Remove Unknown.log file before lens startup (amareshwari: rev 
f8a3879172c923d5ceac76c3d853b77eea002ca9)
* (edit) tools/conf/server/logback.xml
* (edit) tools/scripts/lens-ctl


> Remove Unknown.log file before lens startup
> ---
>
> Key: LENS-1409
> URL: https://issues.apache.org/jira/browse/LENS-1409
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: default_query_id.patch
>
>
> unknown.log is created and appended if queryId is not defined. it is reaching 
> a large size. We can delete it while lens-server startup. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972236#comment-15972236
 ] 

Hadoop QA commented on LENS-1391:
-

Applied patch: 
[LENS-1391.patch|https://issues.apache.org/jira/secure/attachment/12863752/LENS-1391.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1248/

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch, LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Rajitha R (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972210#comment-15972210
 ] 

Rajitha R edited comment on LENS-1405 at 4/18/17 6:53 AM:
--

[~amareshwari]
Done.


was (Author: rajitha.r):
[~amaresh852] 
Done.

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: lens_latest.patch, Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Rajitha R (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1405:

Status: Patch Available  (was: Open)

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: lens_latest.patch, Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Rajitha R (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1405:

Attachment: lens_latest.patch

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: lens_latest.patch, Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1393) Update the javax mail version to current

2017-04-18 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972207#comment-15972207
 ] 

Hudson commented on LENS-1393:
--

FAILURE: Integrated in Jenkins build Lens-Commit #1392 (See 
[https://builds.apache.org/job/Lens-Commit/1392/])
LENS-1393 : Upgrade javax mail version (amareshwari: rev 
b94fc5be3f3338db2200b068a2d92e02b2dfddf5)
* (edit) pom.xml


> Update the javax mail version to current
> 
>
> Key: LENS-1393
> URL: https://issues.apache.org/jira/browse/LENS-1393
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1393.patch
>
>
> Sending mail with the older version of javax mail was causing threads to 
> stuck because of connection timeout to the mail server was not honored. 
> Updating to the new version solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Rajitha R (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1405:

Status: Patch Available  (was: Open)

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58496: Review comments on the MaxCoveringFactResolver

2017-04-18 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58496/
---

Review request for lens and Puneet Gupta.


Bugs: LENS-1391
https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
---

Comments and cleanup


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 1c0d356 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
a9bd164 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
34180d1 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
d95cf27 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 064da01 


Diff: https://reviews.apache.org/r/58496/diff/1/


Testing
---


Thanks,

Lavkesh Lahngir

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1391:
--
Attachment: (was: LENS-1391.patch)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1391:
--
Attachment: (was: LENS-1391.patch)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

2017-04-18 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1391:
--
Attachment: (was: LENS-1391.patch)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1409) Remove Unknown.log file before lens startup

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1409:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh]

> Remove Unknown.log file before lens startup
> ---
>
> Key: LENS-1409
> URL: https://issues.apache.org/jira/browse/LENS-1409
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: default_query_id.patch
>
>
> unknown.log is created and appended if queryId is not defined. it is reaching 
> a large size. We can delete it while lens-server startup. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972179#comment-15972179
 ] 

Amareshwari Sriramadasu commented on LENS-1405:
---

[~rajitha.r] Also create patch file as .patch, for precommit build to run. 

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1405) Xsd for virtual fact

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1405:
--
Fix Version/s: 2.7
   Status: Open  (was: Patch Available)

[~rajitha.r] Can you update here the final patch after review?

> Xsd for virtual fact
> 
>
> Key: LENS-1405
> URL: https://issues.apache.org/jira/browse/LENS-1405
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.7
>
> Attachments: Lens-patch
>
>
> To define a xsd for virtual fact.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1394) Create DOAP file

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1394:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1394.01.patch
>
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1393) Update the javax mail version to current

2017-04-18 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1393:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh]

> Update the javax mail version to current
> 
>
> Key: LENS-1393
> URL: https://issues.apache.org/jira/browse/LENS-1393
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1393.patch
>
>
> Sending mail with the older version of javax mail was causing threads to 
> stuck because of connection timeout to the mail server was not honored. 
> Updating to the new version solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)