date:20170504


[ 
https://issues.apache.org/jira/browse/LENS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996678#comment-15996678
 ] 

Hadoop QA commented on LENS-1417:
-

Applied patch: 
[LENS-1417.03.patch|https://issues.apache.org/jira/secure/attachment/12866386/LENS-1417.03.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1288/

> Add filters in cli create schema command
> 
>
> Key: LENS-1417
> URL: https://issues.apache.org/jira/browse/LENS-1417
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1417.01.patch, LENS-1417.02.patch, 
> LENS-1417.03.patch
>
>
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1417) Add filters in cli create schema command


[ 
https://issues.apache.org/jira/browse/LENS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996626#comment-15996626
 ] 

Rajat Khandelwal commented on LENS-1417:


Taking patch from reviewboard and attaching

> Add filters in cli create schema command
> 
>
> Key: LENS-1417
> URL: https://issues.apache.org/jira/browse/LENS-1417
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1417.01.patch, LENS-1417.02.patch, 
> LENS-1417.03.patch
>
>
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1417) Add filters in cli create schema command


 [ 
https://issues.apache.org/jira/browse/LENS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1417:
---
Attachment: LENS-1417.03.patch

> Add filters in cli create schema command
> 
>
> Key: LENS-1417
> URL: https://issues.apache.org/jira/browse/LENS-1417
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1417.01.patch, LENS-1417.02.patch, 
> LENS-1417.03.patch
>
>
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

2017-05-04 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
---

(Updated May 4, 2017, 5:45 p.m.)


Review request for lens.


Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417


Repository: lens


Description
---

create schema command is useful but it calls create/update for all the schema 
xml files. The following things will be useful:

* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in 
their names
* Reporting all Failures collectively at the end.

The general flow in cli is to run a command, then for subsequent runs of the 
same command, one generally tends to use the command history and modify 
existing commands. So although there already exists a way to solve for point 2, 
but it involves writing another command. Having this filter will be helpful.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
76cb8b90e206eea076cf32b87d97617a833c3f91 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
60bd9e074848c8579f1ad4edcd8e4873f40c4843 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
cdd101bfa4b6ce77492e1626491e58e570be03af 


Diff: https://reviews.apache.org/r/58956/diff/3/

Changes: https://reviews.apache.org/r/58956/diff/2-3/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

2017-05-04 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996624#comment-15996624
 ] 

Hudson commented on LENS-1419:
--

SUCCESS: Integrated in Jenkins build Lens-Commit #1402 (See 
[https://builds.apache.org/job/Lens-Commit/1402/])
LENS-1419: UnionCandidates getting pruned when only dim attributes 
(rajatgupta59: rev 2448336da1033d0d037fcaa875650528612df161)
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java


> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

2017-05-04 Thread Rajat Khandelwal



> On May 4, 2017, 5:42 p.m., Puneet Gupta wrote:
> > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
> > Lines 108 (patched)
> > 
> >
> > Is this required ?

removed


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173892
---


On May 4, 2017, 5:02 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> ---
> 
> (Updated May 4, 2017, 5:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> 
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> 
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> 76cb8b90e206eea076cf32b87d97617a833c3f91 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> 60bd9e074848c8579f1ad4edcd8e4873f40c4843 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> cdd101bfa4b6ce77492e1626491e58e570be03af 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
>  2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
> 80ba912f43de4686f27732c54647a715f0514387 
> 
> 
> Diff: https://reviews.apache.org/r/58956/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

2017-05-04 Thread Puneet Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173892
---




lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
Lines 108 (patched)


Is this required ?


- Puneet Gupta


On May 4, 2017, 11:32 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> ---
> 
> (Updated May 4, 2017, 11:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> 
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> 
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> 76cb8b90e206eea076cf32b87d97617a833c3f91 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> 60bd9e074848c8579f1ad4edcd8e4873f40c4843 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> cdd101bfa4b6ce77492e1626491e58e570be03af 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
>  2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
> 80ba912f43de4686f27732c54647a715f0514387 
> 
> 
> Diff: https://reviews.apache.org/r/58956/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996605#comment-15996605
 ] 

Hadoop QA commented on LENS-1419:
-

Applied patch: 
[LENS-1419.patch|https://issues.apache.org/jira/secure/attachment/12866375/LENS-1419.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1286/

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1417) Add filters in cli create schema command


[ 
https://issues.apache.org/jira/browse/LENS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996590#comment-15996590
 ] 

Rajat Khandelwal commented on LENS-1417:


Taking patch from reviewboard and attaching

> Add filters in cli create schema command
> 
>
> Key: LENS-1417
> URL: https://issues.apache.org/jira/browse/LENS-1417
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1417.01.patch, LENS-1417.02.patch
>
>
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1417) Add filters in cli create schema command


 [ 
https://issues.apache.org/jira/browse/LENS-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1417:
---
Attachment: LENS-1417.02.patch

> Add filters in cli create schema command
> 
>
> Key: LENS-1417
> URL: https://issues.apache.org/jira/browse/LENS-1417
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1417.01.patch, LENS-1417.02.patch
>
>
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

2017-05-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
---

(Updated May 4, 2017, 5:02 p.m.)

Review request for lens.

Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417

Repository: lens

Description
---

create schema command is useful but it calls create/update for all the schema
xml files. The following things will be useful:

* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in
their names
* Reporting all Failures collectively at the end.

The general flow in cli is to run a command, then for subsequent runs of the
same command, one generally tends to use the command history and modify
existing commands. So although there already exists a way to solve for point 2,
but it involves writing another command. Having this filter will be helpful.

Diffs (updated)
-

lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java
76cb8b90e206eea076cf32b87d97617a833c3f91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java
60bd9e074848c8579f1ad4edcd8e4873f40c4843
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
cdd101bfa4b6ce77492e1626491e58e570be03af

lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
80ba912f43de4686f27732c54647a715f0514387

Diff: https://reviews.apache.org/r/58956/diff/2/

Changes: https://reviews.apache.org/r/58956/diff/1-2/

Testing
---

Thanks,

Rajat Khandelwal

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1419:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1419:
---
Fix Version/s: 2.7

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996580#comment-15996580
 ] 

Rajat Khandelwal commented on LENS-1419:


Committed. Thanks [~sushilmohanty]

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996569#comment-15996569
 ] 

Hadoop QA commented on LENS-1419:
-

Applied patch: 
[LENS-1419.patch|https://issues.apache.org/jira/secure/attachment/12866375/LENS-1419.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1285/

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Issue Comment Deleted] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1419:
---
Comment: was deleted

(was: +1)

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996544#comment-15996544
 ] 

Puneet Gupta commented on LENS-1419:


+1

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1419:
---
Status: Patch Available  (was: Open)

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996543#comment-15996543
 ] 

Puneet Gupta commented on LENS-1419:


+1

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

2017-05-04 Thread Sushil Mohanty (JIRA)


[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996494#comment-15996494
 ] 

Sushil Mohanty commented on LENS-1419:
--

This patch also includes changes we missed due to merge conflicts in 
CubeSegmentation. 

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

2017-05-04 Thread Sushil Mohanty (JIRA)


 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1419:
-
Attachment: LENS-1419.patch

Small change, attaching patch directly.

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

2017-05-04 Thread Sushil Mohanty (JIRA)

Sushil Mohanty created LENS-1419:


 Summary: UnionCandidates getting pruned when only dim attributes 
projected
 Key: LENS-1419
 URL: https://issues.apache.org/jira/browse/LENS-1419
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


In current code there is a bug which prunes all UnionCandidates when only dim 
attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1418) LensClient is not thread safe


[ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996368#comment-15996368
 ] 

Hadoop QA commented on LENS-1418:
-

Applied patch: 
[LENS-1418.01.patch|https://issues.apache.org/jira/secure/attachment/12866354/LENS-1418.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1284/

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1418) LensClient is not thread safe


[ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996367#comment-15996367
 ] 

Hadoop QA commented on LENS-1418:
-

Applied patch: 
[LENS-1418.01.patch|https://issues.apache.org/jira/secure/attachment/12866354/LENS-1418.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1284/

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1418) LensClient is not thread safe


[ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996320#comment-15996320
 ] 

Rajat Khandelwal commented on LENS-1418:


Taking patch from reviewboard and attaching

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1418) LensClient is not thread safe


 [ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1418:
---
Status: Patch Available  (was: In Progress)

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1418) LensClient is not thread safe


 [ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1418:
---
Attachment: LENS-1418.01.patch

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Work started] (LENS-1418) LensClient is not thread safe


 [ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1418 started by Rajat Khandelwal.
--
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1418) LensClient is not thread safe


[ 
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996317#comment-15996317
 ] 

Rajat Khandelwal commented on LENS-1418:


Created https://reviews.apache.org/r/58986/

> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1418) LensClient is not thread safe