Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-18 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review107005 ---

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-18 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 18, 2015, 4:40 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-18 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review106994 ---

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
> On Nov. 17, 2015, 5:27 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java, > > line 98 > > > > > > Why does it required copyAST

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 17, 2015, 8 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 17, 2015, 7:31 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 18, 2015, 1 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 9, 2015, 6:52 p.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 10, 2015, 2:51 a.m.) Review request for lens. Bugs: LENS-851

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-04 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review105048 --- lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-04 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review105051 --- Can you add tests with some fields selected being expressions,

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-03 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 3, 2015, 7:30 p.m.) Review request for lens. Bugs: LENS-851