Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

We cannot add comments to a json file. https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr Also, I've already excluded .json files while pushing for 629. This issue was discussed as part of LENS-629 also. We're good! On Thu, Oct 8, 2015 at 6:49 PM, Raju Bairishetti wrote: > This is

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

> On Oct. 8, 2015, 1:15 p.m., Raju Bairishetti wrote: > > Seems there is no licence header file in package.json file. We may need to add a check in checkstyle if it is not enforcing header check on json files. - Raju --- This is an aut

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/#review101903 --- Seems there is no licence header file in package.json file. - Raju

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/ --- (Updated Oct. 8, 2015, 1:09 p.m.) Review request for lens, Ajay Yadava, Amaresh

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/#review101900 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 8, 2015, 12

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/ --- (Updated Oct. 8, 2015, 12:26 p.m.) Review request for lens, Ajay Yadava, Amares

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/ --- (Updated Oct. 8, 2015, 12:19 p.m.) Review request for lens, Ajay Yadava, Amares

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

> On Oct. 6, 2015, 6:06 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 3 > > > > > > If the version is hardcoded this way, and not reading through > > ${project.version} variable, it will be diffi

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

> On Oct. 6, 2015, 6:06 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 3 > > > > > > If the version is hardcoded this way, and not reading through > > ${project.version} variable, it will be diffi

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/#review101611 --- lens-ui/package.json (line 3)

Re: Review Request 38758: UI for Saved/Parametrized queries + Bug fixes/Enhancements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38758/ --- (Updated Oct. 6, 2015, 6:06 a.m.) Review request for lens, Ajay Yadava, Amaresh