Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39439/#review103915 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 19, 2015, 2

Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-21 Thread Sushil Mohanty
> On Oct. 21, 2015, 9:44 a.m., Rajat Khandelwal wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, > > lines 635-641 > > > > > > What's the change here? Seems only re

Re: Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-21 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39439/#review103380 --- lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestCol

Review Request 39439: LENS-835 : Optimizing fact subquery by removing non aggregated expression columns from group by clause

2015-10-19 Thread Sushil Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39439/ --- Review request for lens. Bugs: LENS-835 https://issues.apache.org/jira/brow