Re: Review Request 39653: LENS-844: querying a measure with dim attributes not queryable with it gives wrong error

2016-06-16 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39653/
---

(Updated June 16, 2016, 3:33 p.m.)


Review request for lens.


Bugs: LENS-844
https://issues.apache.org/jira/browse/LENS-844


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf 
14ed167e1033893436d923c4a07b20c2e69597ac 
  
lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
 bcd42dc573a7619d6e74ec57f00446f6aa3c8c10 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
e49b58b113d4bd0aa34bcbdb057469223ab9f736 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 78fb21dd65b4dc050f2a69342c242f1948249ea1 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
31d2d2c3bc8517d7634ebf7698a44a981faf4546 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
cf327465367fc4797d096d3d1abf02309a6a799e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
9b5a52f0b3f078c02e75c9e55d5e8b1aafa64aec 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
86db011b57846c45a3d94a29a2ab1cfa35ef2d49 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 fe2dfb3ecd9f735d00897b64e1208ea16307ee1e 
  
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java 
caee12f4a39388c39eac656949e9c16bf4dfdea7 

Diff: https://reviews.apache.org/r/39653/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 39653: LENS-844: querying a measure with dim attributes not queryable with it gives wrong error

2016-06-16 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39653/#review137926
---



Can we update this to latest?

- Amareshwari Sriramadasu


On Oct. 26, 2015, 3:05 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39653/
> ---
> 
> (Updated Oct. 26, 2015, 3:05 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-844
> https://issues.apache.org/jira/browse/LENS-844
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> a582dc266ae98c240489d2fe78fde0887601545e 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  bcd42dc573a7619d6e74ec57f00446f6aa3c8c10 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 73a584f507444ceceb265e8439fab45d0de7a1b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9ea43bba0244555678499799edfba444822b73fd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  f81f3d5975d8604743050d1a5c106039007f871f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 7a92b3b17b87c6d8f71ca5d54b0a77de8ff60caa 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 705f19b5a32a2c47342b435d5ef59be31bf6cd71 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  0fea9f1bb4a266b680a252786ebd9e931d1b0c09 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62 
> 
> Diff: https://reviews.apache.org/r/39653/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 39653: LENS-844: querying a measure with dim attributes not queryable with it gives wrong error

2015-10-30 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39653/#review104568
---



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 71)


Dont we have to the table name out here?



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 155)


I think the error of the TIME_DIM_UNSUPPORTED should also say : "Queried 
data not available for time dimensions: %s" 

I feel this is a better message than saying 'not supported'



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 203)


returning null ?



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
(line 272)


system.out ? Can we remove?


- Amareshwari Sriramadasu


On Oct. 26, 2015, 3:05 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39653/
> ---
> 
> (Updated Oct. 26, 2015, 3:05 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-844
> https://issues.apache.org/jira/browse/LENS-844
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 
> a582dc266ae98c240489d2fe78fde0887601545e 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
>  bcd42dc573a7619d6e74ec57f00446f6aa3c8c10 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
> 73a584f507444ceceb265e8439fab45d0de7a1b3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  9ea43bba0244555678499799edfba444822b73fd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  f81f3d5975d8604743050d1a5c106039007f871f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 7a92b3b17b87c6d8f71ca5d54b0a77de8ff60caa 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 705f19b5a32a2c47342b435d5ef59be31bf6cd71 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  0fea9f1bb4a266b680a252786ebd9e931d1b0c09 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
>  a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62 
> 
> Diff: https://reviews.apache.org/r/39653/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>