Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu



Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39686/
---

(Updated Oct. 27, 2015, 2:04 p.m.)


Review request for lens.


Bugs: LENS-849
https://issues.apache.org/jira/browse/LENS-849


Repository: lens


Description
---

Added regression test with fix. Also fixed comparison in TestQuery for non-join 
queries.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
f81f3d5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 705f19b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
b2a15a0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 2707c4c 

Diff: https://reviews.apache.org/r/39686/diff/


Testing
---

All lens-cube tests succeeded


Thanks,

Amareshwari Sriramadasu