Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-10-19 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/#review153263
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 19, 2016, 9:50 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52341/
> ---
> 
> (Updated Oct. 19, 2016, 9:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1325
> https://issues.apache.org/jira/browse/lens-1325
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Added test cases to test multiple query parsms 
> 2. Test with complex param value that requires encoding at the time of 
> submission
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
>  1760bec 
>   lens-server/src/main/resources/lenssession-default.xml b6bfa2e 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
>  6a57b20 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 415f56f 
>   src/site/apt/admin/session-config.apt c4b3c04 
> 
> Diff: https://reviews.apache.org/r/52341/diff/
> 
> 
> Testing
> ---
> 
> mvn  test 
> -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion"
>  -pl lens-server
> 
> 
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> **Logs form TestQueryNotifictaionResource show params access_token and data 
> are recived correctly** 
> 
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:null
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> --
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> 
> 
> **Logs from lens server show succes for both the urls**
> 
> puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
> successfully" lens-server/target/test.log
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
> http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
>  Response code 204
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
> http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc.
>  Response code 204
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-10-19 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

(Updated Oct. 19, 2016, 9:50 a.m.)


Review request for lens.


Changes
---

- Fixed Review comment 
- Merged with master again


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 1760bec 
  lens-server/src/main/resources/lenssession-default.xml b6bfa2e 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 6a57b20 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
415f56f 
  src/site/apt/admin/session-config.apt c4b3c04 

Diff: https://reviews.apache.org/r/52341/diff/


Testing
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly** 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


**Logs from lens server show succes for both the urls**

puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
successfully" lens-server/target/test.log
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
 Response code 204
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc.
 Response code 204


Thanks,

Puneet Gupta

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-10-03 Thread Amareshwari Sriramadasu 


> On Sept. 29, 2016, 9:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java,
> >  line 1910
> > 
> >
> > Should we encode the full url, instead of only values passed?
> 
> Puneet Gupta wrote:
> lens server is posting notification on the received url as such without 
> modifying it. To do this the base path should not be encoded. only parameter 
> values need to be encoded incase they have special characters. if the 
> parameter values have no special character, encoding is not required.

Should we document this in the property description?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/#review150831
---


On Sept. 28, 2016, 11:18 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52341/
> ---
> 
> (Updated Sept. 28, 2016, 11:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1325
> https://issues.apache.org/jira/browse/lens-1325
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Added test cases to test multiple query parsms 
> 2. Test with complex param value that requires encoding at the time of 
> submission
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
>  f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
>  3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f755508529f6745caadd8eee0f63e81e1f14ed75 
> 
> Diff: https://reviews.apache.org/r/52341/diff/
> 
> 
> Testing
> ---
> 
> mvn  test 
> -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion"
>  -pl lens-server
> 
> 
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> **Logs form TestQueryNotifictaionResource show params access_token and data 
> are recived correctly** 
> 
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:null
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> --
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> 
> 
> **Logs from lens server show succes for both the urls**
> 
> puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
> successfully" lens-server/target/test.log
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-10-02 Thread Puneet Gupta 


> On Sept. 29, 2016, 9:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java,
> >  line 1910
> > 
> >
> > Should we encode the full url, instead of only values passed?

lens server is posting notification on the received url as such without 
modifying it. To do this the base path should not be encoded. only parameter 
values need to be encoded incase they have special characters. if the parameter 
values have no special character, encoding is not required.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/#review150831
---


On Sept. 28, 2016, 11:18 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52341/
> ---
> 
> (Updated Sept. 28, 2016, 11:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1325
> https://issues.apache.org/jira/browse/lens-1325
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Added test cases to test multiple query parsms 
> 2. Test with complex param value that requires encoding at the time of 
> submission
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
>  f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
>  3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f755508529f6745caadd8eee0f63e81e1f14ed75 
> 
> Diff: https://reviews.apache.org/r/52341/diff/
> 
> 
> Testing
> ---
> 
> mvn  test 
> -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion"
>  -pl lens-server
> 
> 
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> **Logs form TestQueryNotifictaionResource show params access_token and data 
> are recived correctly** 
> 
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:null
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> --
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> 
> 
> **Logs from lens server show succes for both the urls**
> 
> puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
> successfully" lens-server/target/test.log
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
>

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-29 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/#review150831
---




lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
(line 1910)


Should we encode the full url, instead of only values passed?


- Amareshwari Sriramadasu


On Sept. 28, 2016, 11:18 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52341/
> ---
> 
> (Updated Sept. 28, 2016, 11:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1325
> https://issues.apache.org/jira/browse/lens-1325
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Added test cases to test multiple query parsms 
> 2. Test with complex param value that requires encoding at the time of 
> submission
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
>  f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
>  3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> f755508529f6745caadd8eee0f63e81e1f14ed75 
> 
> Diff: https://reviews.apache.org/r/52341/diff/
> 
> 
> Testing
> ---
> 
> mvn  test 
> -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion"
>  -pl lens-server
> 
> 
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> **Logs form TestQueryNotifictaionResource show params access_token and data 
> are recived correctly** 
> 
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:null
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> --
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> 
> 
> **Logs from lens server show succes for both the urls**
> 
> puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
> successfully" lens-server/target/test.log
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
> http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
>  Response code 204
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
>

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-28 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

(Updated Sept. 28, 2016, 11:18 a.m.)


Review request for lens.


Changes
---

Updated testing messages


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 

Diff: https://reviews.apache.org/r/52341/diff/


Testing (updated)
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly** 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


**Logs from lens server show succes for both the urls**

puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
successfully" lens-server/target/test.log
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
 Response code 204
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc.
 Response code 204


Thanks,

Puneet Gupta

Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

2016-09-28 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

Review request for lens.


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 f264603c03f3444d2d38e17be9f6b1fcd708d0bf 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 

Diff: https://reviews.apache.org/r/52341/diff/


Testing
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


Thanks,

Puneet Gupta