Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-14 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/#review152655
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 14, 2016, 9:59 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52820/
> ---
> 
> (Updated Oct. 14, 2016, 9:59 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1358
> https://issues.apache.org/jira/browse/LENS-1358
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
>  36cc8fa188f21d5f2e439e2121515799c3f70525 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java
>  a530e9d65e2c84e674b9260aaffbb68a0cbf2f94 
> 
> Diff: https://reviews.apache.org/r/52820/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-14 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
---

(Updated Oct. 14, 2016, 3:29 p.m.)


Review request for lens.


Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
 36cc8fa188f21d5f2e439e2121515799c3f70525 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestQueryContext.java
 a530e9d65e2c84e674b9260aaffbb68a0cbf2f94 

Diff: https://reviews.apache.org/r/52820/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
---

(Updated Oct. 13, 2016, 7:24 p.m.)


Review request for lens.


Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c 

Diff: https://reviews.apache.org/r/52820/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
---

(Updated Oct. 13, 2016, 4:10 p.m.)


Review request for lens.


Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 d0662f4ccfb71a2f56d3cb841c3c399a6cdf713c 

Diff: https://reviews.apache.org/r/52820/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-13 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/#review152468
---




lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java
 (line 28)


Really? do you want to make StatusUpdateListenter serializable ? I feel 
this should be transient.


- Amareshwari Sriramadasu


On Oct. 13, 2016, 8:42 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52820/
> ---
> 
> (Updated Oct. 13, 2016, 8:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1358
> https://issues.apache.org/jira/browse/LENS-1358
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java
>  dcddd1b78e2d01eab632f76a319c8381aeba7735 
> 
> Diff: https://reviews.apache.org/r/52820/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
---

(Updated Oct. 13, 2016, 2:12 p.m.)


Review request for lens.


Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358


Repository: lens


Description
---


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java
 dcddd1b78e2d01eab632f76a319c8381aeba7735 

Diff: https://reviews.apache.org/r/52820/diff/


Testing
---


Thanks,

Rajat Khandelwal

Review Request 52820: LENS-1358: Lens server snapshotter failing when there's a jdbc query running while snapshotting

2016-10-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52820/
---

Review request for lens.


Bugs: LENS-1358
https://issues.apache.org/jira/browse/LENS-1358


Repository: lens


Description
---


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java
 dcddd1b78e2d01eab632f76a319c8381aeba7735 

Diff: https://reviews.apache.org/r/52820/diff/


Testing
---


Thanks,

Rajat Khandelwal