Re: Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60973/#review181026 --- Ship it! Ship It! - Sushil Mohanty On July 20, 2017, 7:51 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60973/ > --- > > (Updated July 20, 2017, 7:51 a.m.) > > > Review request for lens. > > > Bugs: LENS-1455 > https://issues.apache.org/jira/browse/LENS-1455 > > > Repository: lens > > > Description > --- > > in case an expression is answered from a segmentation, the default expression > can't be generated. > > > Diffs > - > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > 69d9562f39c91d050db4b2af5c5c4f9b6161f0f0 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 66b043e51b1a838139090e851d62dcb249fab382 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java > a2bd485005272f5fbb4d71879716f2afb5bc6771 > > > Diff: https://reviews.apache.org/r/60973/diff/3/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
Re: Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60973/ --- (Updated July 20, 2017, 1:21 p.m.) Review request for lens. Bugs: LENS-1455 https://issues.apache.org/jira/browse/LENS-1455 Repository: lens Description --- in case an expression is answered from a segmentation, the default expression can't be generated. Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java 69d9562f39c91d050db4b2af5c5c4f9b6161f0f0 lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 66b043e51b1a838139090e851d62dcb249fab382 lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a2bd485005272f5fbb4d71879716f2afb5bc6771 Diff: https://reviews.apache.org/r/60973/diff/3/ Changes: https://reviews.apache.org/r/60973/diff/2-3/ Testing --- Thanks, Rajat Khandelwal
Re: Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60973/ --- (Updated July 20, 2017, 1 p.m.) Review request for lens. Bugs: LENS-1455 https://issues.apache.org/jira/browse/LENS-1455 Repository: lens Description --- in case an expression is answered from a segmentation, the default expression can't be generated. Diffs (updated) - lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java 69d9562f39c91d050db4b2af5c5c4f9b6161f0f0 lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 66b043e51b1a838139090e851d62dcb249fab382 lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a2bd485005272f5fbb4d71879716f2afb5bc6771 Diff: https://reviews.apache.org/r/60973/diff/2/ Changes: https://reviews.apache.org/r/60973/diff/1-2/ Testing --- Thanks, Rajat Khandelwal
Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60973/ --- Review request for lens. Bugs: LENS-1455 https://issues.apache.org/jira/browse/LENS-1455 Repository: lens Description --- in case an expression is answered from a segmentation, the default expression can't be generated. Diffs - lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 66b043e51b1a838139090e851d62dcb249fab382 Diff: https://reviews.apache.org/r/60973/diff/1/ Testing --- Thanks, Rajat Khandelwal
