Re: [Snowdrift-dev] [PATCH] Make Snowdrift project wiki search redirect to the gitit wiki

[Bryan Richter]

On Tue, May 17, 2016 at 12:25:08PM -0600, Peter Harpending wrote:
> On Tue, May 17, 2016 at 09:12:30PM +0300, fr33domlo...@riseup.net wrote:
> > From: fr33domlover 
> > 
> > ---
> >  website/Snowdrift.cabal | 1 +
> >  website/config/routes   | 1 +
> >  website/src/Handler.hs  | 4 
> >  3 files changed, 6 insertions(+)
> > 
> > diff --git a/website/Snowdrift.cabal b/website/Snowdrift.cabal
> > index 5cf461c..0994000 100644
> > --- a/website/Snowdrift.cabal
> > +++ b/website/Snowdrift.cabal
> > @@ -61,6 +61,7 @@ library
> >  MultiParamTypeClasses
> >  GeneralizedNewtypeDeriving
> >  RecordWildCards
> > +ViewPatterns
> >  
> >  -- build-depends {{{2
> >  build-depends:
> > diff --git a/website/config/routes b/website/config/routes
> > index e2f9d0d..510423c 100644
> > --- a/website/config/routes
> > +++ b/website/config/routes
> > @@ -20,3 +20,4 @@
> >  /merchandise MerchandiseR GET
> >  
> >  /p/snowdrift SnowdriftProjectR GET
> > +/p/snowdrift/w/#Text SnowdriftWikiSearchR GET
> > diff --git a/website/src/Handler.hs b/website/src/Handler.hs
> > index 9506a50..d1c3f1d 100644
> > --- a/website/src/Handler.hs
> > +++ b/website/src/Handler.hs
> > @@ -72,3 +72,7 @@ getMerchandiseR = $(widget "page/merchandise" 
> > "getMerchandiseR")
> >  -- For MVP, there is one, hard-coded project: Snowdrift
> >  getSnowdriftProjectR :: Handler Html
> >  getSnowdriftProjectR = $(widget "page/snowdrift-project" "Snowdrift.coop 
> > Project")
> > +
> > +getSnowdriftWikiSearchR :: Text -> Handler Html
> > +getSnowdriftWikiSearchR slug =
> > +redirect $ "https://wiki.snowdrift.coop/_search?patterns=; <> slug
> > -- 
> > 1.9.1
> 
> I don't have colorized diffs in my email client, so take my input with a grain
> of salt.  That said, it looks fine, and this is a good feature to add. My only
> question is: why do we need ViewPatterns? I'm not necessarily opposed to it, 
> I'm
> just curious.

The default scaffolding uses them. I removed them as "unused" when I
set up the new scaffolded code. It was a bit hasty. :)


signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

Re: [Snowdrift-dev] [PATCH] Make Snowdrift project wiki search redirect to the gitit wiki

[Peter Harpending]

On Tue, May 17, 2016 at 09:12:30PM +0300, fr33domlo...@riseup.net wrote:
> From: fr33domlover 
> 
> ---
>  website/Snowdrift.cabal | 1 +
>  website/config/routes   | 1 +
>  website/src/Handler.hs  | 4 
>  3 files changed, 6 insertions(+)
> 
> diff --git a/website/Snowdrift.cabal b/website/Snowdrift.cabal
> index 5cf461c..0994000 100644
> --- a/website/Snowdrift.cabal
> +++ b/website/Snowdrift.cabal
> @@ -61,6 +61,7 @@ library
>  MultiParamTypeClasses
>  GeneralizedNewtypeDeriving
>  RecordWildCards
> +ViewPatterns
>  
>  -- build-depends {{{2
>  build-depends:
> diff --git a/website/config/routes b/website/config/routes
> index e2f9d0d..510423c 100644
> --- a/website/config/routes
> +++ b/website/config/routes
> @@ -20,3 +20,4 @@
>  /merchandise MerchandiseR GET
>  
>  /p/snowdrift SnowdriftProjectR GET
> +/p/snowdrift/w/#Text SnowdriftWikiSearchR GET
> diff --git a/website/src/Handler.hs b/website/src/Handler.hs
> index 9506a50..d1c3f1d 100644
> --- a/website/src/Handler.hs
> +++ b/website/src/Handler.hs
> @@ -72,3 +72,7 @@ getMerchandiseR = $(widget "page/merchandise" 
> "getMerchandiseR")
>  -- For MVP, there is one, hard-coded project: Snowdrift
>  getSnowdriftProjectR :: Handler Html
>  getSnowdriftProjectR = $(widget "page/snowdrift-project" "Snowdrift.coop 
> Project")
> +
> +getSnowdriftWikiSearchR :: Text -> Handler Html
> +getSnowdriftWikiSearchR slug =
> +redirect $ "https://wiki.snowdrift.coop/_search?patterns=; <> slug
> -- 
> 1.9.1

I don't have colorized diffs in my email client, so take my input with a grain
of salt.  That said, it looks fine, and this is a good feature to add. My only
question is: why do we need ViewPatterns? I'm not necessarily opposed to it, I'm
just curious.

-- 
Peter Harpending


signature.asc
Description: Digital signature
___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev

[Snowdrift-dev] [PATCH] Make Snowdrift project wiki search redirect to the gitit wiki

[fr33domlover]

From: fr33domlover 

---
 website/Snowdrift.cabal | 1 +
 website/config/routes   | 1 +
 website/src/Handler.hs  | 4 
 3 files changed, 6 insertions(+)

diff --git a/website/Snowdrift.cabal b/website/Snowdrift.cabal
index 5cf461c..0994000 100644
--- a/website/Snowdrift.cabal
+++ b/website/Snowdrift.cabal
@@ -61,6 +61,7 @@ library
 MultiParamTypeClasses
 GeneralizedNewtypeDeriving
 RecordWildCards
+ViewPatterns
 
 -- build-depends {{{2
 build-depends:
diff --git a/website/config/routes b/website/config/routes
index e2f9d0d..510423c 100644
--- a/website/config/routes
+++ b/website/config/routes
@@ -20,3 +20,4 @@
 /merchandise MerchandiseR GET
 
 /p/snowdrift SnowdriftProjectR GET
+/p/snowdrift/w/#Text SnowdriftWikiSearchR GET
diff --git a/website/src/Handler.hs b/website/src/Handler.hs
index 9506a50..d1c3f1d 100644
--- a/website/src/Handler.hs
+++ b/website/src/Handler.hs
@@ -72,3 +72,7 @@ getMerchandiseR = $(widget "page/merchandise" 
"getMerchandiseR")
 -- For MVP, there is one, hard-coded project: Snowdrift
 getSnowdriftProjectR :: Handler Html
 getSnowdriftProjectR = $(widget "page/snowdrift-project" "Snowdrift.coop 
Project")
+
+getSnowdriftWikiSearchR :: Text -> Handler Html
+getSnowdriftWikiSearchR slug =
+redirect $ "https://wiki.snowdrift.coop/_search?patterns=; <> slug
-- 
1.9.1

___
Dev mailing list
Dev@lists.snowdrift.coop
https://lists.snowdrift.coop/mailman/listinfo/dev