Re: Logging list for emails generated by tools

2017-10-15 Thread Ralph Goers
It seems there is a self-service tool to create the mailing list. Ralph > On Oct 15, 2017, at 3:15 PM, Ralph Goers wrote: > > I have opened a Jira issue with Infra to do this. > > Ralph > >> On Oct 13, 2017, at 12:46 PM, Mikael Ståldal wrote: >>

Re: Logging list for emails generated by tools

2017-10-15 Thread Ralph Goers
I have opened a Jira issue with Infra to do this. Ralph > On Oct 13, 2017, at 12:46 PM, Mikael Ståldal wrote: > > Sounds like a good idea. > > > On 2017-10-12 22:34, Ralph Goers wrote: >> What do others think about the idea of creating a separate mailing list for >> emails

[jira] [Commented] (LOG4J2-2076) Split up log4j-nosql into one module per appender

2017-10-15 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205320#comment-16205320 ] Ralph Goers commented on LOG4J2-2076: - I wasn't thinking that nosql would generate a jar. I would

[jira] [Commented] (LOG4J2-2076) Split up log4j-nosql into one module per appender

2017-10-15 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205309#comment-16205309 ] Matt Sicker commented on LOG4J2-2076: - It could be. All the classes directly in this package:

[jira] [Commented] (LOG4J2-2076) Split up log4j-nosql into one module per appender

2017-10-15 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205301#comment-16205301 ] Ralph Goers commented on LOG4J2-2076: - Does it make sense to make nosql a multi-module parent for

[jira] [Commented] (LOG4J2-2076) Split up log4j-nosql into one module per appender

2017-10-15 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205300#comment-16205300 ] Matt Sicker commented on LOG4J2-2076: - You may want to move some of the common code back in to

Re: Planning out what we can do to get Chainsaw back in the game

2017-10-15 Thread Matt Sicker
Java 8 or Scala 2.12 are my personal choices. While Java 9 would be cool to use, yeah, it's still a bit early there. Thankfully, Chainsaw is primarily a GUI, so maintaining compatibility with older JVMs is unnecessary. With Java 9, we should be able to bundle just the modules needed to make a

[jira] [Created] (LOG4J2-2076) Split up log4j-nosql into one module per appender

2017-10-15 Thread JIRA
Mikael Ståldal created LOG4J2-2076: -- Summary: Split up log4j-nosql into one module per appender Key: LOG4J2-2076 URL: https://issues.apache.org/jira/browse/LOG4J2-2076 Project: Log4j 2

Re: Planning out what we can do to get Chainsaw back in the game

2017-10-15 Thread Mikael Ståldal
I also think it is a bit to early to depend on Java 9. However, we should depend on (and make use of) Java 8. Not sure if Java 9 give any substanstial benefits in this project (Java 8 definitely does). If we want to rewrite it completely, I would go for Scala 2.12 (on JVM 8). I don't think

Re: Java Modules

2017-10-15 Thread Ralph Goers
You are welcome to create a Jira issue and do it! Ralph > On Oct 15, 2017, at 12:50 PM, Mikael Ståldal wrote: > > On 2017-10-15 07:40, Ralph Goers wrote: >> I have committed the code for LOG4J2-2056. Log4j-api is a “real” module and >> has a module-info.java while all the

[GitHub] logging-log4j2 pull request #117: Feature/log4 j2 2062 lookup

2017-10-15 Thread mikaelstaldal
Github user mikaelstaldal commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/117#discussion_r144729853 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/appender/mom/kafka/KafkaAppenderTest.java --- @@ -22,8 +22,8 @@ import

Re: Java Modules

2017-10-15 Thread Mikael Ståldal
On 2017-10-15 07:40, Ralph Goers wrote: I have committed the code for LOG4J2-2056. Log4j-api is a “real” module and has a module-info.java while all the rest that can be modularized are automatic modules. Please review and test. I don't think we should modularize log4j-nosql. I think we

Re: Planning out what we can do to get Chainsaw back in the game

2017-10-15 Thread Matt Sicker
Java 8 should certainly be the base line supported version for the next version. We can use Java 6 for a sort of snapshot in time of what we have already, then begin work toward Chainsaw 3.0. On 15 October 2017 at 14:23, Ralph Goers wrote: > Java 8 also has a

Re: Planning out what we can do to get Chainsaw back in the game

2017-10-15 Thread Ralph Goers
Java 8 also has a replacement for SimpleDateFormat that should perform much better than SimpleDateFormat. Ralph > On Oct 15, 2017, at 12:10 PM, Matt Sicker wrote: > > On 14 October 2017 at 23:34, Scott Deboy wrote: > >> Parsing time strings to their

Re: Planning out what we can do to get Chainsaw back in the game

2017-10-15 Thread Matt Sicker
On 14 October 2017 at 23:34, Scott Deboy wrote: > Parsing time strings to their numeric values using SimpleDateFormat is > painfully slow - I don't even use it any longer when I'm looking at > 1M+ rows in Chainsaw. > For the JSON and binary formats, we can output

Re: Java Modules

2017-10-15 Thread Ralph Goers
I just remembered that option 2 wouldn’t be sufficient as it would only export at run time. The implementation needs access at compile time. I remember there are ways to achieve this but I don’t recall what they are at the moment, but I seem to recall is still requires calling module.exports.

Re: Java Modules

2017-10-15 Thread Ralph Goers
Yes, you can target specific packages for exposure to specific modules. Yes, we would want to move the classes that are “private” to a sub package of util if we were to do that. As for the name, yes you could specify multiple exports but that would mean we would need to know the name of every

[jira] [Created] (LOG4J2-2075) Add module information to extended stack trace.

2017-10-15 Thread Ralph Goers (JIRA)
Ralph Goers created LOG4J2-2075: --- Summary: Add module information to extended stack trace. Key: LOG4J2-2075 URL: https://issues.apache.org/jira/browse/LOG4J2-2075 Project: Log4j 2 Issue Type:

Re: Java Modules

2017-10-15 Thread Remko Popma
You mean we may want to do something like this in the future? module org.apache.logging.log4j { exports org.apache.logging.log4j; exports org.apache.logging.log4j.message; exports org.apache.logging.log4j.simple; exports org.apache.logging.log4j.spi; exports

Jenkins build is still unstable: Log4j 2.x #3126

2017-10-15 Thread Apache Jenkins Server
See

Jenkins build became unstable: Log4j 2.x #3125

2017-10-15 Thread Apache Jenkins Server
See

[jira] [Commented] (LOG4J2-2056) Modularize Log4j as automatic modules

2017-10-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205120#comment-16205120 ] ASF subversion and git services commented on LOG4J2-2056: - Commit

[jira] [Commented] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-15 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205113#comment-16205113 ] Remko Popma commented on LOG4J2-2060: - I've committed a fix to master. It would be great if you could

[jira] [Commented] (LOG4J2-2060) AbstactDatabase appender issue with AsyncLogger

2017-10-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205112#comment-16205112 ] ASF subversion and git services commented on LOG4J2-2060: - Commit

[jira] [Commented] (LOG4J2-2062) Add possibility of sending the key of a message to Kafka using KafkaAppender

2017-10-15 Thread Jorge Sanchez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205078#comment-16205078 ] Jorge Sanchez commented on LOG4J2-2062: --- I have created a new PR for the key lookup capability at

[jira] [Commented] (LOG4J2-2067) Using PatternSelectors breaks header printing in PatternLayout

2017-10-15 Thread Paul Burrowes (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205055#comment-16205055 ] Paul Burrowes commented on LOG4J2-2067: --- This tests the patch. I would create a PR but I'm a bit

Re: Java Modules

2017-10-15 Thread Ralph Goers
FWIW, I am still torn on whether log4j-core should have a module name of org.apache.logging.log4j.core or org.apache.logging.log4j.impl. If it is the second then log4j-api could restrict exporting packages only meant for the implementation to that module. That would require some refactoring of

[jira] [Commented] (LOG4J2-2056) Modularize Log4j as automatic modules

2017-10-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205050#comment-16205050 ] ASF subversion and git services commented on LOG4J2-2056: - Commit