Re: logging-log4j2 git commit: LOG4J2-2087 Jansi now needs to be enabled explicitly (by setting system property `log4j.skipJansi` to `false`). To avoid causing problems for web applications, Log4j wil

2017-10-23 Thread Matt Sicker
Can you use the new system property naming scheme? This would be log4j2.skipJansi. That property would work regardless with the new system properties parser thing, though the documentation should be more consistent now. On 23 October 2017 at 22:14, wrote: > Repository:

Re: Test failures in log4j-taglib

2017-10-23 Thread Remko Popma
The error went away on my machine and the Jenkins build started passing after reverting back to 3.2.18.RELEASE > On Oct 24, 2017, at 4:51, Ralph Goers wrote: > > OK. So I am guessing that the errors are happening on a unit test that uses > Spring’s mock classes

Re: Test failures in log4j-taglib

2017-10-23 Thread Ralph Goers
OK. So I am guessing that the errors are happening on a unit test that uses Spring’s mock classes and those were upgraded in 4.x to support Servlet 3.0. Ralph > On Oct 23, 2017, at 11:46 AM, Mikael Ståldal wrote: > > It happened when Spring Framework was upgraded to 4.x. >

Re: Test failures in log4j-taglib

2017-10-23 Thread Gary Gregory
On Mon, Oct 23, 2017 at 12:14 PM, Ralph Goers wrote: > So does this mean that log4j-taglib no longer supports servlet 2.5? How > did this happen with no changes? > No idea. Matt mentioned the change did not break anything so I made the change to the POM. I can see

Re: Test failures in log4j-taglib

2017-10-23 Thread Mikael Ståldal
It happened when Spring Framework was upgraded to 4.x. On 2017-10-23 20:14, Ralph Goers wrote: So does this mean that log4j-taglib no longer supports servlet 2.5? How did this happen with no changes? Ralph On Oct 23, 2017, at 8:21 AM, Gary Gregory wrote: On Thu,

Re: Test failures in log4j-taglib

2017-10-23 Thread Ralph Goers
So does this mean that log4j-taglib no longer supports servlet 2.5? How did this happen with no changes? Ralph > On Oct 23, 2017, at 8:21 AM, Gary Gregory wrote: > > On Thu, Oct 19, 2017 at 2:14 PM, Ralph Goers

Re: Import Ordering - ImpSort

2017-10-23 Thread Matt Sicker
I don't know if I'll have time to review any PRs for a few days. Anyone else is welcome to review in the meantime. On 23 October 2017 at 12:27, kenneth mcfarland wrote: > Hi Matt, I opened a pull request that contains the maven plugin we looked > at. > > See

Re: Import Ordering - ImpSort

2017-10-23 Thread kenneth mcfarland
Hi Matt, I opened a pull request that contains the maven plugin we looked at. See LOG4J2-2086. I tested this locally under the API folder and it rocks. I know an IDE can do this, but not an entire repository and force it on every build. Nobody can manually verify every file or guarantee other

Re: Test failures in log4j-taglib

2017-10-23 Thread Gary Gregory
On Thu, Oct 19, 2017 at 2:14 PM, Ralph Goers wrote: > I am wondering why this is suddenly failing. Was it changed recently? > > Ralph > > > On Oct 19, 2017, at 1:00 PM, Mikael Ståldal wrote: > > > > The missing class,