Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Matt Sicker
I've reverted a couple errant commits that introduced test failures. Besides the RollingDirectSizeTimeNewDirectoryTest test, the remaining failures are Windows-specific. On Sat, 12 Sep 2020 at 13:06, Ralph Goers wrote: > > Gary, I think you misunderstood. It may be another week before I start the

Re: [VOTE] [log4net] Release 2.0.10

2020-09-12 Thread Davyd McColl
Thanks Ralph I want aware I could get the site live like that, but now that I know, I'll lbs better next time. -d On September 12, 2020 20:03:02 Ralph Goers wrote: I checked out the asf-site branch and ran “git rebase asf-staging” and then committed that. The 2.0.10 site is live. Ralph

Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Ralph Goers
Gary, I think you misunderstood. It may be another week before I start the release. Yes, the build issues need to be addressed. I was laying out my process before starting a release. I am suggesting that there should be time to fix the build and look at PRs and Jira issues before the release is

Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Matt Sicker
Summary of failing tests: * JsonWriterTest has some linkage errors only showing up on Windows? * SpringLookupTest is consistently failing only on Windows * EquinoxLoadApiBundleTest is failing everywhere with some class signing error (related to that OSGi dependency update I mentioned) * RollingDir

Re: [VOTE] [log4net] Release 2.0.10

2020-09-12 Thread Ralph Goers
I checked out the asf-site branch and ran “git rebase asf-staging” and then committed that. The 2.0.10 site is live. Ralph > On Sep 12, 2020, at 10:50 AM, Ralph Goers wrote: > > Davyd, > > You have full access to all Logging repos at GitHub. You can publish the > log4net site yourself just

Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Gary Gregory
I think focusing on fixing the build should come before considering bringing in PRs or Jira issues. I think Matt stated we don't get a clean build ATM? Gary On Sat, Sep 12, 2020, 13:55 Ralph Goers wrote: > Yeah, I rely mostly on the automation but I run the build on my Mac > several times befor

Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Ralph Goers
Yeah, I rely mostly on the automation but I run the build on my Mac several times before a release and if any of them fail I wouldn’t even start the release process. I still am working on my $dayjob project and would still want to take a look at open Jira issues before starting the release. I wo

Re: [VOTE] [log4net] Release 2.0.10

2020-09-12 Thread Ralph Goers
Davyd, You have full access to all Logging repos at GitHub. You can publish the log4net site yourself just by committing it to the asf-site branch. The only thing preventing that would be if you want others to review the staged site before you do that. In looking at the log4net site, it reli

Re: JsonTemplateLayout is ready to be shipped!

2020-09-12 Thread Matt Sicker
Seems like one of the things we need to do before the release candidate is get all the tests passing again. I'll look more into any test failures introduced from my JUnit 5 refactoring. We do have test failures related to OSGi at the moment due to a dependency update, though that might be due to in

Re: [VOTE] [log4net] Release 2.0.10

2020-09-12 Thread Davyd McColl
Thanks Ralph I've pushed the nuget package; links to download artifacts in the site pushed as oy2ky5qgzop2i5hcbgsayxy3rqtvgqnenj2usfjzgansye to asf-staging seem to be fine, tested locally, though I don't see that version of the site up at  https://logging.staged.apache.org/log4net; however, it's