changes.xml

2021-03-04 Thread Ralph Goers
Looking at changes.xml it looks like actions that are being fixed in 2.14.1 in the release-2.x branch and 3.0.0 in master. This will create confusion for users when 3.0.0 is released as we will be listing a pile of fixes that were actually fixed in prior releases. Please add the actions to th

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles. (#471)

2021-03-04 Thread Ralph Goers
Ahh, ok. I guess I didn’t look closely at the diff. Just noticed it was still using SimpleDateFormat and you had changed the line. Ralph > On Mar 4, 2021, at 8:54 AM, Volkan Yazıcı wrote: > > I did neither replace the usage of SimpleDateFormat in release-2.x, nor > implemented myself DateTimeF

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles. (#471)

2021-03-04 Thread Volkan Yazıcı
I did neither replace the usage of SimpleDateFormat in release-2.x, nor implemented myself DateTimeFormatter in master. I have just touched to the indentation in release-2.x. I deliberately left it out since it wasn't related to the ticket and I could not invest time into figuring out the reason fo

Re: [logging-log4j2] branch release-2.x updated: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles. (#471)

2021-03-04 Thread Ralph Goers
I am curious. I noticed in master you used DateTimeFormatter. The minimum version for Log4j 2.x is now Java 8. Why didn’t you use it here too? Ralph > On Mar 4, 2021, at 3:56 AM, v...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > vy pushed a comm

LOG4J2-2948 Use IdentityHashMap for ParameterFormatter deja vu

2021-03-04 Thread Volkan Yazıcı
PR has been merged to release-2.x and cherry-pick'ed onto master, FYI.

Re: [log4cxx] Smart pointer implementation

2021-03-04 Thread Thorsten Schöning
Guten Tag Robert Middleton, am Donnerstag, 4. März 2021 um 00:46 schrieben Sie: > Sounds good. I'll update that in the coming days/weeks - I have a > deadline approaching for work, so I may not be able to do much for a > bit. If you know to run out of time at some point, consider pushing your br