Re: Cek's new log4j vs logback benchmark

2021-09-21 Thread Carter Kozak
Thanks, Volkan! Rerunning the benchmarks on my branch (specifically the PatternLayout benchmarks in log4j-perf) produced much better improvements than I had anticipated. Beyond that, the date format cache invalidation problem resulted in a substantial speedup. I agree that it would be helpful t

[VOTE] Release log4cxx 0.12.1

2021-09-21 Thread Robert Middleton
This is a vote to release log4cxx 0.12.1. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... This vote will remain open for 72 hours(or more if required). All votes are welcome and we encourage everyone to test th

Re: Event (Message) Template idea for JSON Template Layout

2021-09-21 Thread Ron Grabowski
StringMapMessage offers similar functionality. That's the concept I was looking for, thanks On Tuesday, September 21, 2021, 03:12:16 AM EDT, Volkan Yazıcı wrote: What advantage(s) does it provide compared to simply logging a `MapMessage`? Consider the following: StringMapMessage mess

Re: Cek's new log4j vs logback benchmark

2021-09-21 Thread Volkan Yazıcı
First and foremost, fantastic job Carter! For #573, I see that Gary and Ralph have already shared some remarks. I would appreciate it if we can get this merged and cut the ribbon for 2.15.0 release. Regarding `StringBuilder#toString().getBytes()`-vs-`CharsetEncoder`... That is a tough one. In you

Re: Event (Message) Template idea for JSON Template Layout

2021-09-21 Thread Volkan Yazıcı
What advantage(s) does it provide compared to simply logging a `MapMessage`? Consider the following: StringMapMessage message = new StringMapMessage(); message.put("Kind", "engine start"); message.put("Instant", "2016-09-28T23:28:51.224Z"); message.put("NextScheduledInstant", "2016-09-29T23:28:51.