Re: PropertyKey abstraction

2024-01-04 Thread Gary Gregory
FWIW, I'm NOT a fan of the static analysis option. Good design should be reflected in the code. We should not pick suboptimal abstractions (or no abstraction in this case) plus static analysis to validate odd design choices. Gafy On Thu, Jan 4, 2024, 11:29 AM Piotr P. Karwasz wrote: > Hi Ralph,

Re: PropertyKey abstraction

2024-01-04 Thread Piotr P. Karwasz
Hi Ralph, On Thu, 4 Jan 2024 at 16:20, Ralph Goers wrote: > > PropertyKey was created so that all “components” could be specified as an > enum value, thus ensuring consistency. > > The split between component and key is used in every declaration of a > property. > > It is unfortunate that the k

Re: PropertyKey abstraction

2024-01-04 Thread Ralph Goers
PropertyKey was created so that all “components” could be specified as an enum value, thus ensuring consistency. The split between component and key is used in every declaration of a property. It is unfortunate that the keys also had to be specified as static constants so they could be used

PropertyKey abstraction

2024-01-04 Thread Piotr P. Karwasz
Hi all, Looking at the `PropertyKey` abstraction in `3.x`, I was wondering what advantages it brings over simple string constants. From my perspective it has more cons than pros. Pros: * it is typesafe; a committer must create an instance of it to use it; Cons: * it is hard to list for docum