[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-07 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 issue #106: LOG4J2-1997 This cleans up the entire test packag...

2017-08-07 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/106 And thanks for your input, but I think my time would be better served somewhere else where people don't refer the COD for calling out some childish commenting and capital letters. Take

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

2017-08-04 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/106 LOG4J2-1997 This cleans up the entire test package of import wildcards… …, deprecated methods, typos and other trivial issues. You can merge this pull request into a Git repository by

[GitHub] logging-log4j2 pull request #104: LOG4J-1997 Cleanup of deprecated methods, ...

2017-08-03 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 issue #104: LOG4J-1997 Cleanup of deprecated methods, warning...

2017-08-03 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/104 I will create a new patch and pull request that addresses the minimal set of changes to close LOG4J2-1997. Although the changes are fairly trivial, I realize that 27 files might be too large

[GitHub] logging-log4j2 issue #104: LOG4J-1997 Cleanup of deprecated methods, warning...

2017-08-02 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/104 I've also made some more changes to reflect consistent non wildcard imports, spacing of imports, etc that makes the core test package look a little cleaner. --- If your project is s

[GitHub] logging-log4j2 issue #104: LOG4J-1997 Cleanup of deprecated methods, warning...

2017-08-02 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/104 Please let me know if you have any other feedback, I have removed the useless getter method. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] logging-log4j2 issue #104: LOG4J-1997 Cleanup of deprecated methods, warning...

2017-08-02 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/104 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] logging-log4j2 issue #104: LOG4J-1997 Cleanup of deprecated methods, warning...

2017-08-01 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/104 Remove eclipse warning for the unused field unless you think the getter is a big deal On Aug 1, 2017 2:45 PM, "Gary Gregory" wrote: > *@garydgregory* comm

[GitHub] logging-log4j2 pull request #104: LOG4J-1997 Cleanup of deprecated methods, ...

2017-07-31 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/104 LOG4J-1997 Cleanup of deprecated methods, warnings and use of try-with-resource to remove resource leaks. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...

2017-07-31 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...

2017-07-31 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/103 LOG4J2-1997 Remove deprecated methods and close resource leaks. This closes the jira. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] logging-log4j2 pull request #101: LOG4J2-Fix type warnings and remove deprec...

2017-07-28 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/101 LOG4J2-Fix type warnings and remove deprecated methods where appropriate Unit tests pass. Maven builds successfully. You can merge this pull request into a Git repository by running

[GitHub] logging-log4j2 pull request #100: LOG4J2-1991 - Refactor SimpleMessage to be...

2017-07-26 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/100 LOG4J2-1991 - Refactor SimpleMessage to be concise and clear with the use of approp… …riate ternary statements. All test have been ran from the log4j2-api root and pass with build

[GitHub] logging-log4j2 pull request #99: LOG4J2-1989 - Clarify javadoc for AbstractT...

2017-07-26 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/99 LOG4J2-1989 - Clarify javadoc for AbstractTriggeringPolicy.java This clarifies the javadoc for AbstractTriggeringPolicy. You can merge this pull request into a Git repository by running

[GitHub] logging-log4j2 pull request #98: Remove a large number of empty comments in ...

2017-07-24 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/98 Remove a large number of empty comments in Generate.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/kpm1985/logging-log4j2 cleanup

[GitHub] logging-log4j2 pull request #97: (doc) remove empty comments

2017-07-21 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/97 (doc) remove empty comments sorry for all the noise. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kpm1985/logging-log4j2 cleanup

[GitHub] logging-log4j2 pull request #96: Remove empty comments and fix default buffe...

2017-07-21 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 pull request #96: Remove empty comments and fix default buffe...

2017-07-21 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/96 Remove empty comments and fix default buffer size to match documentation. I have removed empty comments and changed the default buffer sizes in certain implementations to match the

[GitHub] logging-log4j2 pull request #95: Kpm1985

2017-07-21 Thread kpm1985
Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 issue #95: Kpm1985

2017-07-21 Thread kpm1985
Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/95 While reading through the PDF user guide, I have noticed on page 88 the default buffer size is indeed intended to be 8192. If this PR is dirty and needs to be cleaned up please let me know

[GitHub] logging-log4j2 pull request #95: Kpm1985

2017-07-20 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/95 Kpm1985 I have cleaned up a few files and removed empty comments. The default buffer size in certain implementations was 8102, which I believe was a typo because 8192 is a power of two

[GitHub] logging-log4j2 pull request #94: remove unnecessary/empty comment

2017-07-19 Thread kpm1985
GitHub user kpm1985 opened a pull request: https://github.com/apache/logging-log4j2/pull/94 remove unnecessary/empty comment the title says it all You can merge this pull request into a Git repository by running: $ git pull https://github.com/kpm1985/logging-log4j2 master