Re: [log4j] Move JDBC appender to own module?

My main complaint with core is the amount of time it takes to run unit tests. I don’t think the JDBC tests are a big contributor to that. Ralph > On Jan 13, 2018, at 6:34 PM, Gary Gregory wrote: > > On Jan 13, 2018 16:11, "Remko Popma" wrote: > > JDCB doesn’t require an external dependency s

Re: [log4j] Move JDBC appender to own module?

On Jan 13, 2018 16:11, "Remko Popma" wrote: JDCB doesn’t require an external dependency so why split it off into a separate module? So that core is thinner. Maybe that is not a big deal. Some folks complain more about the size of the API module. Gary This page is outdated now: https://loggin

Re: [log4j] Move JDBC appender to own module?

JDCB doesn’t require an external dependency so why split it off into a separate module? This page is outdated now: https://logging.apache.org/log4j/2.x/runtime-dependencies.html (Shameless plug) Every java main() method deserves http://picocli.info > On Jan 14, 2018, at 3:43, Gary Gregory wr

Re: [log4j] Move JDBC appender to own module?

I created: LOG4J2-2188 Split off JPA support into a new module log4j-jpa LOG4J2-2187 Split off JDBC support into a new module log4j-jdbc

Re: [log4j] Move JDBC appender to own module?

On Jan 13, 2018 09:54, "Mikael Ståldal" wrote: As usual, I think we should avoid optional dependencies. That means more modules. Maybe we can start small here with a log4j-jpa module. Gary On 2018-01-13 10:16, Remko Popma wrote: > I meant to keep the jdbc and the generic db package toget

Re: [log4j] Move JDBC appender to own module?

As usual, I think we should avoid optional dependencies. On 2018-01-13 10:16, Remko Popma wrote: I meant to keep the jdbc and the generic db package together. log4j-db: generic db + jdbc log4j-jpa: requires javax.persistance We can also keep all of these in a single module `log4j-db` with an

Re: [log4j] Move JDBC appender to own module?

I meant to keep the jdbc and the generic db package together. log4j-db: generic db + jdbc log4j-jpa: requires javax.persistance We can also keep all of these in a single module `log4j-db` with an optional dependency on javax.persistance. More modules gives more flexibility but also more complex

Re: [log4j] Move JDBC appender to own module?

I won't touch the modules. I think we need hash it out a little more and get a consensus. If there are 2 modules: JPA and JDBC, then the generic .db package needs to stay in log4j-core. Which would be OK for now. Gary On Fri, Jan 12, 2018 at 11:16 PM, Remko Popma wrote: > Okay perhaps just two

Re: [log4j] Move JDBC appender to own module?

Okay perhaps just two modules then? By the way, I have work in progress on the high-precision time stamps that would be impacted by this. I would like to avoid the merge conflict by postponing this module breakdown until that is merged. Is that possible? (Shameless plug) Every java main() metho

Re: [log4j] Move JDBC appender to own module?

The reason to split out JPA would be to avoid bringing in the dependency to javax.persistenance which is not in the JRE. The JDBC API OTOH is in the JRE. Gary On Fri, Jan 12, 2018 at 10:14 PM, Remko Popma wrote: > How about moving all of these (generic database support, jdbc and jpa) > together

Re: [log4j] Move JDBC appender to own module?

How about moving all of these (generic database support, jdbc and jpa) together into a single separate module? Something like: log4j-db I don’t see much value into splitting them up further, but perhaps that’s just me. Remko (Shameless plug) Every java main() method deserves http://picocli

[log4j] Move JDBC appender to own module?

Hi All: I wonder if we should move the JDBC Appender to its own module. Also wondering how we would then slice and dice the generic database support and the JPA Appender: - log4j-db - log4j-jdbc - log4j-jpa Those would all be small modules... ? Thank you, Gary