Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-09 Thread Gary Gregory
Hi, I just fixed one test issue: in RandomAccessFileManagerTest.testAppendDoesNotOverwriteExistingFile One more to go. Gary On Mon, Nov 9, 2020, 10:24 Ralph Goers wrote: > Gary, > > If you find that the Windows issues are not problems in the tests please > let us know as that could be

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-09 Thread Ralph Goers
Gary, If you find that the Windows issues are not problems in the tests please let us know as that could be considered a blocker. But if you can find and fix the problems to the tests that would be appreciated. If not, I can try to do it when I get spare cycles to run it in a VM. Ralph >

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-09 Thread Gary Gregory
I found a way to fix the test failure on my Mac mini in TestConfigurator by increasing sleep times and committed that to release-2.x. So now my Mac build is completed with 'mvn clean install' :-) Windows still fails as noted previously and I'll see if I have time to look into failures before the

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-08 Thread Gary Gregory
On Sun, Nov 8, 2020 at 12:03 PM Matt Sicker wrote: > There’s a system property you can override in the tests to increase the > file cleanup timeout which seems to help ensure the tests end up passing in > I'm sorry to say that my experience with this RC on both Macos and Windows feels like our

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-08 Thread Matt Sicker
There’s a system property you can override in the tests to increase the file cleanup timeout which seems to help ensure the tests end up passing in Windows. If you try setting it to like 1 or 2 seconds, that might help. On Sun, Nov 8, 2020 at 10:49 Ralph Goers wrote: > That aligns with what we

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-08 Thread Ralph Goers
That aligns with what we see in Jenkins. They appear to be problems with the tests trying to cleanup. Not a blocker for the release. Ralph > On Nov 8, 2020, at 8:46 AM, Gary Gregory wrote: > > From the git tags, my failures on Windows are: > > [INFO] > [ERROR] Failures: > [ERROR]

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-08 Thread Gary Gregory
>From the git tags, my failures on Windows are: [INFO] [ERROR] Failures: [ERROR] FileOutputTest.testConfig target\status.log failed with java.nio.file.FileSystemException: target\status.log: The process cannot access the file because it is being used by another process. [ERROR] Errors: [ERROR]

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-07 Thread Ralph Goers
+1 Tested using mvn -version Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T12:00:29-07:00) Maven home: /opt/maven/maven Java version: 1.8.0_265, vendor: Amazon.com Inc., runtime: /Library/Java/JavaVirtualMachines/amazon-corretto-8.jdk/Contents/Home/jre Default

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-07 Thread Matt Sicker
+1 Signatures and checksums good, builds and tests fine, site looks good. Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec Java version: 1.8.0_242, vendor: AdoptOpenJDK, runtime:

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-07 Thread Gary Gregory
Would you all mind replying with what OS, Java versions, build commands, an so on, you validated the release candidate? I think it would be good to know FTR what kind of coverage we got for a RC. Gary On Fri, Nov 6, 2020, 19:51 Volkan Yazıcı wrote: > +1 > > Thanks so much to everyone who put

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-07 Thread Remko Popma
+1 Remko. On Sat, Nov 7, 2020 at 8:46 AM Ralph Goers wrote: > This is a vote to release Log4j 2.14.0, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... > > The

Re: [VOTE] Release Log4j 2.14.0-rc1

2020-11-06 Thread Volkan Yazıcı
+1 Thanks so much to everyone who put effort into this release. Keep up the good work! On Sat, 7 Nov 2020, 00:46 Ralph Goers wrote: > This is a vote to release Log4j 2.14.0, the next version of the Log4j 2 > project. > > Please download, test, and cast your votes on the log4j developers list.