Re: Testing Json Template Layout

2020-07-22 Thread Apache
Yes, please do. Ralph > On Jul 22, 2020, at 6:22 AM, Volkan Yazıcı wrote: > > Ralph, I am fine with the current state of the plugin. I don't intend to > have further improvements in the short-term regarding KeyValuePair > enhancements and/or escape character handling. If you are okay with it,

Re: Testing Json Template Layout

2020-07-22 Thread Volkan Yazıcı
Ralph, I am fine with the current state of the plugin. I don't intend to have further improvements in the short-term regarding KeyValuePair enhancements and/or escape character handling. If you are okay with it, I want to start rebasing this onto 2.x branch. On Mon, Jul 6, 2020 at 8:01 AM Ralph Go

Re: Testing Json Template Layout

2020-07-12 Thread Ralph Goers
Maybe. But it isn’t obvious and would have to be explicitly documented. Ralph > On Jul 12, 2020, at 8:09 AM, Matt Sicker wrote: > > Wouldn’t that be � in XML? > > On Sat, Jul 11, 2020 at 16:26 Ralph Goers > wrote: > >> I guess what you mean is that where you have $resolver: “message” that >>

Re: Testing Json Template Layout

2020-07-12 Thread Matt Sicker
Wouldn’t that be � in XML? On Sat, Jul 11, 2020 at 16:26 Ralph Goers wrote: > I guess what you mean is that where you have $resolver: “message” that > would somehow be replaced by $resolver” “pattern”? That would make sense. > I have no problem with the changes you are suggesting. However, you

Re: Testing Json Template Layout

2020-07-11 Thread Ralph Goers
I guess what you mean is that where you have $resolver: “message” that would somehow be replaced by $resolver” “pattern”? That would make sense. I have no problem with the changes you are suggesting. However, you should also change the configuration shown in cloud.md and the log4j2.xml in log4

Re: Testing Json Template Layout

2020-07-11 Thread Volkan Yazıcı
I can't believe how were we expecting somebody to pass a null character from an XML file! Long story short, it was the XML parser, doing the right thing, that is, converting XML attribute value "\0" to Java String "\\0". Okay, I am not gonna whine about this anymore. I have just pushed a commit add

Re: Testing Json Template Layout

2020-07-11 Thread Volkan Yazıcı
Reading your changes again, I think your `MessageResolver` improvements are a clone of `PatternResolver`. Hence, I will revert the `MessageResolver` changes. Objections? (Sorry that it took awhile for me to get it clicked. Saturday evening...) On Sat, Jul 11, 2020 at 8:37 PM Volkan Yazıcı wrote:

Re: Testing Json Template Layout

2020-07-11 Thread Volkan Yazıcı
Hello Ralph! Sorry that it took me this long to reply to you back in detail, but I have just found time to do so. Let me try to address the points you raised: > The first problem I ran into is that additional fields don’t work. > I don’t see any configurations that have them and the Builder doesn

Re: Testing Json Template Layout

2020-07-08 Thread Ralph Goers
A couple other things. As I was implementing stuff I noticed you implemented stuff using lots of static methods. I am not really sure why since almost all of those methods are only invoked from an instance of the object. I had to change that to get my enhancements to work. Also, I would like to

Re: Testing Json Template Layout

2020-07-08 Thread Volkan Yazıcı
Hey Ralph, Thanks so much for taking time, really appreciated. Unfortunately the last few days I was pretty busy both at home and at work. I will check out your changes and reply back as soon as I find some time. Kind regards. On Wed, Jul 8, 2020 at 1:08 AM Ralph Goers wrote: > > Volkan, > > I

Re: Testing Json Template Layout

2020-07-07 Thread Ralph Goers
Volkan, I have updated the relevant documentation. I am done with all the changes I wanted to make. Ralph > On Jul 6, 2020, at 2:50 PM, Ralph Goers wrote: > > I have fixed the issue with the annotations. I have added the ability to > format the message field using a pattern and I have modifi

Re: Testing Json Template Layout

2020-07-06 Thread Ralph Goers
I have fixed the issue with the annotations. I have added the ability to format the message field using a pattern and I have modified the code so that specifying eventDelimiter=“null” will insert a null at the end of the message as specifying eventDelimiter=“\0” or “\u000” does not work (It ends