Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

> On Jan 26, 2018, at 8:54 PM, Remko Popma wrote: > > I guess the classes in util/datetime can be moved to the new time package. > Note that these are public classes so there is a probability that a user is > using these classes directly and this move will break their

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

I guess the classes in util/datetime can be moved to the new time package. Note that these are public classes so there is a probability that a user is using these classes directly and this move will break their code, but if we judge this probability to be low and the argument could be made that

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

I’m not crazy about adding date related stuff directly to the util package. I am not thrilled that we have date/time related stuff there when we have a datetime package they could have been placed in. Since we already have a datetime package there and if those classes could be moved to

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

On Sat, Jan 27, 2018 at 8:30 Remko Popma wrote: > > On Jan 26, 2018, at 21:19, Remko Popma wrote: > > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

> On Jan 26, 2018, at 21:19, Remko Popma wrote: > > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes in util cannot be moved as > that would break user code. I’m actually

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

Sounds good to me! On 26 January 2018 at 06:19, Remko Popma wrote: > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes in util cannot be moved as > that would break user code.

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

I moved the new precise time-related classes to a new package core.time as requested by Gary. Note that the preexisting time-related classes in util cannot be moved as that would break user code. On Fri, Jan 26, 2018 at 8:59 PM, Remko Popma wrote: > I renamed

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

I renamed DummyPreciseClock to FixedPreciseClock since it is similar to the Java 8 Clock::fixed factory method. On Thu, Jan 25, 2018 at 9:55 AM, Matt Sicker wrote: > Aren't the classes in datetime copied from commons? Might be simpler to > keep that package uncluttered for

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

Aren't the classes in datetime copied from commons? Might be simpler to keep that package uncluttered for easier updates. Also, I like the name ConstantClock or something like that. Constant is a nice term with appropriate mathematical connotations. On 24 January 2018 at 12:00, Gary Gregory

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

On Wed, Jan 24, 2018 at 10:55 AM, Gary Gregory wrote: > > > On Wed, Jan 24, 2018 at 8:58 AM, Remko Popma > wrote: > >> I see what you mean. Hmm... >> >> FYI, this feature (LOG4J2-1883) adds the following classes. I added them >> to >> core.util,

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

On Wed, Jan 24, 2018 at 8:58 AM, Remko Popma wrote: > I see what you mean. Hmm... > > FYI, this feature (LOG4J2-1883) adds the following classes. I added them to > core.util, but they could still be moved to another package: > * Instant > * PreciseClock > *

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

I see what you mean. Hmm... FYI, this feature (LOG4J2-1883) adds the following classes. I added them to core.util, but they could still be moved to another package: * Instant * PreciseClock * MutableInstant * DummyPreciseClock * SystemMillisClock I would not consider moving the existing

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

Hi, The package core.time is starting to look like a kitchen sink. Why not put this new class into the existing core.util.datetime or into a new core.time package. IMO core.util.datetime, should be core.datetime or simply core.util.time. Gary On Wed, Jan 24, 2018 at 4:22 AM,