Re: [log4j] The shape of Log4j

2018-01-26 Thread Remko Popma
Perhaps https://issues.apache.org/jira/browse/LOG4J2-2226 (Log4j2 modularization) can also function as the epic for moving towards the plugin API that Matt mentioned. (Shameless plug) Every java main() method deserves http://picocli.info > On Jan 25, 2018, at 9:45, Matt Sicker

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Ralph Goers
> On Jan 26, 2018, at 8:54 PM, Remko Popma wrote: > > I guess the classes in util/datetime can be moved to the new time package. > Note that these are public classes so there is a probability that a user is > using these classes directly and this move will break their

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Remko Popma
I guess the classes in util/datetime can be moved to the new time package. Note that these are public classes so there is a probability that a user is using these classes directly and this move will break their code, but if we judge this probability to be low and the argument could be made that

Re: remove Chainsaw's site code from git?

2018-01-26 Thread Matt Sicker
Anything you can do to improve the site would be awesome! Do you think you can copy my svn site changes back into the source? On Fri, Jan 26, 2018 at 17:00, Remko Popma wrote: > No objection from me. We may want to think about how to maintain the > Chainsaw site going

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Ralph Goers
I’m not crazy about adding date related stuff directly to the util package. I am not thrilled that we have date/time related stuff there when we have a datetime package they could have been placed in. Since we already have a datetime package there and if those classes could be moved to

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Remko Popma
On Sat, Jan 27, 2018 at 8:30 Remko Popma wrote: > > On Jan 26, 2018, at 21:19, Remko Popma wrote: > > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Remko Popma
> On Jan 26, 2018, at 21:19, Remko Popma wrote: > > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes in util cannot be moved as > that would break user code. I’m actually

Re: remove Chainsaw's site code from git?

2018-01-26 Thread Remko Popma
No objection from me. We may want to think about how to maintain the Chainsaw site going forward, but having a stale duplicate is asking for problems so I’d say remove it ASAP. (Shameless plug) Every java main() method deserves http://picocli.info > On Jan 27, 2018, at 6:19, Scott Deboy

remove Chainsaw's site code from git?

2018-01-26 Thread Scott Deboy
I haven't looked much at the src/site tree of Chainsaw, but it's clear that the 'real' site code in svn was seeded from Chainsaw's src/site at one point, but src/site is now stale. Can I blow that directory away and remove any site-related targets from Chainsaw's pom? Thanks, Scott

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Matt Sicker
Sounds good to me! On 26 January 2018 at 06:19, Remko Popma wrote: > I moved the new precise time-related classes to a new package core.time as > requested by Gary. > > Note that the preexisting time-related classes in util cannot be moved as > that would break user code.

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Remko Popma
I moved the new precise time-related classes to a new package core.time as requested by Gary. Note that the preexisting time-related classes in util cannot be moved as that would break user code. On Fri, Jan 26, 2018 at 8:59 PM, Remko Popma wrote: > I renamed

Re: logging-log4j2 git commit: LOG4J2-1883 moved SystemMillisClock out of the java9 module into core so it can be used with any supported Java version

2018-01-26 Thread Remko Popma
I renamed DummyPreciseClock to FixedPreciseClock since it is similar to the Java 8 Clock::fixed factory method. On Thu, Jan 25, 2018 at 9:55 AM, Matt Sicker wrote: > Aren't the classes in datetime copied from commons? Might be simpler to > keep that package uncluttered for