> On May 30, 2022, at 2:26 PM, Matt Sicker wrote:
>
> When I was working on the previous iteration of the DI API, I had a
> BeanProcessor which generated different metadata for different annotation
> scenarios. It wasn’t too complex compared to the existing annotation
> processor, though I
> On May 30, 2022, at 1:41 PM, Volkan Yazıcı wrote:
>
> On Mon, May 30, 2022 at 6:52 PM Ralph Goers
> wrote:
>
>>> On May 30, 2022, at 2:01 AM, Volkan Yazıcı wrote:
>>> Following up on the responses, I will ask another question: In 3.x, can't
>>> we deprecate either key or name and stick
When I was working on the previous iteration of the DI API, I had a
BeanProcessor which generated different metadata for different annotation
scenarios. It wasn’t too complex compared to the existing annotation processor,
though I ended up sticking with the existing processor for now since that
On Mon, May 30, 2022 at 6:52 PM Ralph Goers
wrote:
> > On May 30, 2022, at 2:01 AM, Volkan Yazıcı wrote:
> > Following up on the responses, I will ask another question: In 3.x, can't
> > we deprecate either key or name and stick to only one?
>
> Why? What problem does this solve?
>
> > For
And it’s much simpler than moving the BOM around. Very nice!
—
Matt Sicker
> On May 30, 2022, at 09:44, Apache wrote:
>
> It is implemented on master.
>
> Ralph
>
>> On May 30, 2022, at 2:27 AM, Volkan Yazıcı wrote:
>>
>> Mind somebody sharing the last state? Is it implemented, if so how
The annotations could index even more info if we wanted. ConverterKeys is
another annotation that was introduced due to, uh, I don’t know why actually.
Seems like it could use PluginAliases already to define extra converter keys.
Non-core namespace plugins could potentially make use of some of
> On May 30, 2022, at 2:01 AM, Volkan Yazıcı wrote:
>
>> plugin entry interfaces
>
> As Matt has indicated, we indeed need to keep `PluginEntry#interfaces` for
> lazy loading – plus a new `PluginEntry#order` field.
>
>> plugin name vs key
>
> Following up on the responses, I will ask
It is implemented on master.
Ralph
> On May 30, 2022, at 2:27 AM, Volkan Yazıcı wrote:
>
> Mind somebody sharing the last state? Is it implemented, if so how and on
> which branch(es)? Is it reverted? If so, totally or partially?
>
>> On Sun, May 29, 2022 at 9:53 AM Ralph Goers
>> wrote:
>>
It the db location could be changed to the target folder.
Gary
On Mon, May 30, 2022, 07:33 Gary Gregory wrote:
> I've run into this before and yes the test should delete its database on
> completion but obviously does not.
>
> Gary
>
> On Mon, May 30, 2022, 03:10 Piotr P. Karwasz
> wrote:
>
I've run into this before and yes the test should delete its database on
completion but obviously does not.
Gary
On Mon, May 30, 2022, 03:10 Piotr P. Karwasz
wrote:
> On Mon, 30 May 2022 at 09:01, Ralph Goers
> wrote:
>
> > I always run mvn clean install. If there is something else that needs
Hi Ralph,
On Mon, 30 May 2022 at 09:11, Ralph Goers
wrote:
> I ran it multiple times in my Windows VM and it failed each time. I am not
> going
> to hunt down what directories I need to be deleting. The test needs to do
> that.
>
I perfectly understand your POV. Actually looking at the test's
Mind somebody sharing the last state? Is it implemented, if so how and on
which branch(es)? Is it reverted? If so, totally or partially?
On Sun, May 29, 2022 at 9:53 AM Ralph Goers
wrote:
> That is OK. I have reverted your commit and am testing the build for a
> second time doing it the correct
> plugin entry interfaces
As Matt has indicated, we indeed need to keep `PluginEntry#interfaces` for
lazy loading – plus a new `PluginEntry#order` field.
> plugin name vs key
Following up on the responses, I will ask another question: In 3.x, can't
we deprecate either key or name and stick to
Matt, mind elaborating a bit on what exactly is the problem and how will a
fork fix that?
On Sat, May 28, 2022 at 2:27 AM Matt Sicker wrote:
> The fact that the bot uses branches in our repo rather than a fork of
> the repo causes a shitload of bot spam.
>
I ran it multiple times in my Windows VM and it failed each time. I am not
going
to hunt down what directories I need to be deleting. The test needs to do that.
Since H2 is only used for testing I don’t consider it a big deal. The link you
provided clearly shows it is a test dependency so
On Mon, 30 May 2022 at 09:01, Ralph Goers
wrote:
> I always run mvn clean install. If there is something else that needs to
> be cleaned up
> the test should be taking care of it.
>
I totally agree, I'll find the tests that use H2 and fix them tonight.
Piotr
> On May 29, 2022, at 9:12 PM, Piotr P. Karwasz wrote:
>
> Hi Ralph,
>
> On Mon, 30 May 2022 at 00:14, Ralph Goers
> wrote:
>
>> Running the test individually shows
>>
>> Caused by: org.h2.mvstore.MVStoreException: The write format 1 is smaller
>> than the supported format 2 [2.1.212/5]
Hi Ralph,
On Mon, 30 May 2022 at 00:26, Ralph Goers
wrote:
> FWIW, the h2 upgrade broke the build. I am in the process of reverting the
> version change.
>
> Ralph
>
I would really like the H2 upgrade to be included in 2.18.0, so that pages
like this:
18 matches
Mail list logo
