[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop I did that for log4j-core only. Yes, it passes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 Do all tests pass when you run `mvn clean install` on your machine? (may take ~20 minutes) On Wednesday, May 10, 2017 12:34 AM, Roman Leventov wrote:

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop this test used to depend on specific line numbers in this test. Made it more generic. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @remkop thanks for review. Replaced custom class in ThreadLocal with `Object[]`. Fixed a bug in `TextEncoderHelper`, `ThrowableProxyTest.testCircularSuppressedExceptions()` passes now. ---

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 Apologies for the delay. I now have some time to start looking at this again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user remkop commented on the issue: https://github.com/apache/logging-log4j2/pull/71 @leventov Quick update: Started to look at the PR but did not get far yet. I'm taking my time because this is a fairly sensitive area. When converting the OutputStreamAppender and

[GitHub] logging-log4j2 issue #71: [LOG4J2-1874] Add ByteBufferDestionation.write(Byt...

Github user leventov commented on the issue: https://github.com/apache/logging-log4j2/pull/71 > A complicating factor is that there may be users who subclassed any of these classes, and we don't want to break their stuff. If users could implement `ByteBufferDestination`,