Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Apache
My +1 Dominic, if you are going to vote you need to do it formally. Ralph > On Sep 10, 2020, at 12:57 AM, Dominik Psenner wrote: > > Knowing that those changes are intentional I am confident that the next > release is better than the last. This is reason enough to move on. If > something

Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Matt Sicker
I'll have time to review the release over the weekend. I'm going on PTO starting this weekend, too, so I'll likely be doing stuff here a few random days over the next couple weeks, too. On Thu, 10 Sep 2020 at 02:57, Dominik Psenner wrote: > > Knowing that those changes are intentional I am

Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Dominik Psenner
Knowing that those changes are intentional I am confident that the next release is better than the last. This is reason enough to move on. If something breaks we can still address those issues with another future release. -- Sent from my phone. Typos are a kind gift to anyone who happens to find

Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Davyd McColl
Hi Dominik I have had a long look over the changes (both via the PR and locally, as I contributed to help with some infra changes) and I'm happy -- there's been a lot of clean-up and simplification and in addition, tests are now run against all targets -- so that's a good thing. Some of these

Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Dominik Psenner
Hi Sorry to not have responded earlier. Time is short and the days are busy. I looked at the diff and found several suspicious changes. Several hundred ifdefs have been removed/replaced along with tests. Therefore I have a bad feeling about those changes without further careful checking. I

Re: [VOTE] [log4net] Release log4net 2.0.10

2020-09-10 Thread Davyd McColl
Hi Sorry to be a bother, but I haven't heard anything back on this apart from Dominik's inquiry into netstandard 1.3 support. I'd really like to get this out as: a) it contains the CVE fix that has been asked about so much b) it solves some issues affecting netstandard users Thanks -d On