To to that would require 2 test modules. The first would generate the test
classes that are used by both the unit tests and downstream modules. The second
would be the unit tests themselves.
However, I have doubts that that would work. As I said, Maven allows an
essentially illegal
> Note that all of this occurs ONLY because we are creating a test jar that
will be used by other modules.
If it would simplify the build setup, why don't we migrate test-jars to
their individual Maven modules? For instance, log4j-core and
log4j-core-test, etc.
On Tue, Apr 6, 2021 at 5:11 AM
Nothing in Commons requires more than Java 8. JPMS support is done as one
offs here and there with automatic module names.
I don't see it getting better and really supporting JPMS until a component
requires Java 11, the next LTS version after 8. That might not be for a
while... IBM does not
> On Apr 5, 2021, at 1:31 PM, Volkan Yazıcı wrote:
>
>> ... this weird structure with two test source directories ...
>
> doesn't seem okay to me. Please, don't get me wrong. Not that I know of
> JPMS or anything, though this sttructure doesn't resemble anything I have
> ever seen. I don't
> ... this weird structure with two test source directories ...
doesn't seem okay to me. Please, don't get me wrong. Not that I know of
JPMS or anything, though this sttructure doesn't resemble anything I have
ever seen. I don't want to believe that every major Java library with JPMS
support
I was able to fix the OSGi tests simply by upgrading the Maven Bundle Plugin.
The Warning message coming from the compiler plugin was because the
module-info.java file had a requires transitive org.osgi.core and OSGi core is
not a JPMS module. But that really isn’t correct since JPMS and OSGi
The maven verify error is something that affects the master branch too.
Something to do with snapshots and depending on them inter-module. I don’t
know enough about maven to explain why, but some modules require other
modules to have been installed and not just packaged.
On Fri, Apr 2, 2021 at
Well, log4j-api, log4j-plugins and log4j-core each have unit tests and test
classes that are used by other log4j-modules. Because log4j-api and
log4j-plugins are JPMS modules the unit tests need to a) either be in a
different package or b) have a module-info.java that essentially extends the
Great work Ralph!
Your change set marks an important milestone in Log4j development.
Thanks so much!
`./mvnw verify` fails for me while compiling the 2nd module, log4j-api:
`error: module not found: org.osgi.core`. Any ideas?
This said `./mvnw package` succeeds for me, hence all(?) tests pass.
$
Looks okay on Windows. I built on Windows 10 with Zulu Java 8 / 11 in my
toolchain and Maven 3.6.3 and it succeeded after I disabled the usual
culprits:
* log4j-core fails due to the file locking issue with the status logger
* log4j-layout-template-json failed with a port unavailable issue.
I
Actually, they don’t disappear. They just move to closed status. I believe you
can still comment but it is far less noticeable after it is merged. Really, I
suggest you check out the branch and build it. I really didn’t change much
code. I mostly moved it around and changed whatever was needed
I am still reviewing it.
As Matt noted, you can merge it.
This said, I'd appreciate an extra week.
It is easier to discuss changes over GitHub PR.
Once committed, PR will disappear.
On Thu, Apr 1, 2021 at 5:58 AM Ralph Goers
wrote:
> FYI - I plan on merging this code Friday morning MST unless
I have no problem with that. I’ll still go through the code either way ;)
On Wed, Mar 31, 2021 at 22:58 Ralph Goers
wrote:
> FYI - I plan on merging this code Friday morning MST unless my schedule
> changes between now and then.
>
> Ralph
>
> > On Mar 29, 2021, at 3:58 PM, Ralph Goers
> wrote:
FYI - I plan on merging this code Friday morning MST unless my schedule changes
between now and then.
Ralph
> On Mar 29, 2021, at 3:58 PM, Ralph Goers wrote:
>
> I should have added that you may need a recent version of the JDK. I forget
> what error I was encountering but upgrading the JDK
I should have added that you may need a recent version of the JDK. I forget
what error I was encountering but upgrading the JDK to a later version fixed
it. But then I noticed that the Google java allocation instrumenter wasn’t
working and it had to be upgraded too.
Ralph
> On Mar 29, 2021,
I’ll make sure to look more closely at it this week. Nice work on
simplifying the modules a bit!
On Sun, Mar 28, 2021 at 18:24 Ralph Goers
wrote:
> I have created https://github.com/apache/logging-log4j2/pull/480 for you
> to review. It has many changes and merge conflicts will be painful to
I have created https://github.com/apache/logging-log4j2/pull/480 for you to
review. It has many changes and merge conflicts will be painful to fix so
please do not commit to master until this PR is merged.
Although I could merge this now I would prefer if you could checkout the branch
on your
17 matches
Mail list logo
