Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/7445/
Java: 64bit/jdk-11-ea+23 -XX:-UseCompressedOops -XX:+UseParallelGC
30 tests failed.
FAILED:
org.apache.solr.ltr.store.rest.TestModelManagerPersistence.testWrapperModelPersistence
Error Message:
Software caused connection
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/2410/
Java: 32bit/jdk1.8.0_172 -client -XX:+UseParallelGC
2 tests failed.
FAILED: org.apache.solr.cloud.cdcr.CdcrBidirectionalTest.testBiDir
Error Message:
Captured an uncaught exception in thread: Thread[id=222,
Build: https://builds.apache.org/job/Lucene-Solr-repro/1033/
[...truncated 41 lines...]
[repro] Jenkins log URL:
https://builds.apache.org/job/Lucene-Solr-Tests-7.x/697/consoleText
[repro] Revision: 9dc6cff38a2de26a249659d1dc8240aa716b674c
[repro] Repro line: ant test
Build: https://builds.apache.org/job/Lucene-Solr-BadApples-NightlyTests-7.x/19/
16 tests failed.
FAILED:
org.apache.lucene.store.TestMockDirectoryWrapper.testThreadSafetyInListAll
Error Message:
Captured an uncaught exception in thread: Thread[id=30, name=Thread-8,
state=RUNNABLE,
Build: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-master/105/
3 tests failed.
FAILED: org.apache.solr.cloud.api.collections.ShardSplitTest.test
Error Message:
Wrong doc count on shard1_0. See SOLR-5309 expected:<179> but was:<181>
Stack Trace:
java.lang.AssertionError: Wrong doc
[
https://issues.apache.org/jira/browse/LUCENE-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555079#comment-16555079
]
Steve Rowe commented on LUCENE-8135:
I opened LUCENE-8427 for a reproducing failure of
Steve Rowe created LUCENE-8427:
--
Summary: TestBlockMaxConjunction.testRandom() reproducing failure
Key: LUCENE-8427
URL: https://issues.apache.org/jira/browse/LUCENE-8427
Project: Lucene - Core
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Solaris/744/
Java: 64bit/jdk1.8.0 -XX:+UseCompressedOops -XX:+UseParallelGC
4 tests failed.
FAILED:
org.apache.solr.handler.component.InfixSuggestersTest.testShutdownDuringBuild
Error Message:
junit.framework.AssertionFailedError:
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1990/
Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseG1GC
1 tests failed.
FAILED: org.apache.solr.cloud.cdcr.CdcrBidirectionalTest.testBiDir
Error Message:
Captured an uncaught exception in thread: Thread[id=35337,
Build: https://builds.apache.org/job/Lucene-Solr-SmokeRelease-master/1076/
No tests ran.
Build Log:
[...truncated 22998 lines...]
[asciidoctor:convert] asciidoctor: ERROR: about-this-guide.adoc: line 1:
invalid part, must have at least one section (e.g., chapter, appendix, etc.)
[
https://issues.apache.org/jira/browse/LUCENE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554946#comment-16554946
]
Lucene/Solr QA commented on LUCENE-8425:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-MacOSX/764/
Java: 64bit/jdk-9 -XX:+UseCompressedOops -XX:+UseG1GC
All tests passed
Build Log:
[...truncated 14623 lines...]
[junit4] JVM J1: stdout was not empty, see:
[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554890#comment-16554890
]
Varun Thacker commented on SOLR-12587:
--
I've put out a patch which is just exploring the idea .
[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-12587:
-
Attachment: SOLR-12587.patch
> Reuse Lucene's PriorityQueue for the ExportHandler
>
Build: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-7.x/110/
4 tests failed.
FAILED:
org.apache.solr.cloud.api.collections.ShardSplitTest.testSplitWithChaosMonkey
Error Message:
We think that split was successful but sub-shard states were not updated even
after 2 minutes.
Stack
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/2408/
Java: 64bit/jdk-10.0.1 -XX:+UseCompressedOops -XX:+UseSerialGC
1 tests failed.
FAILED: org.apache.solr.TestDistributedSearch.test
Error Message:
Expected to find shardAddress in the up shard info:
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/22518/
Java: 64bit/jdk1.8.0_172 -XX:+UseCompressedOops -XX:+UseG1GC
1 tests failed.
FAILED: junit.framework.TestSuite.org.apache.solr.util.TestSystemIdResolver
Error Message:
The test or suite printed 9208 bytes to stdout and
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554736#comment-16554736
]
Amrit Sarkar edited comment on SOLR-12572 at 7/24/18 8:34 PM:
--
Thanks Varun;
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: SOLR-12572.patch
> Reuse fieldvalues computed while sorting at writing in ExportWriter
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: (was: S-12572.patch)
> Reuse fieldvalues computed while sorting at writing in
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: S-12572.patch
> Reuse fieldvalues computed while sorting at writing in ExportWriter
>
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: (was: S-12572.patch)
> Reuse fieldvalues computed while sorting at writing in
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: S-12572.patch
> Reuse fieldvalues computed while sorting at writing in ExportWriter
>
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: (was: S-12572.patch)
> Reuse fieldvalues computed while sorting at writing in
[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554746#comment-16554746
]
Varun Thacker edited comment on SOLR-12587 at 7/24/18 8:16 PM:
---
Here's a
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: (was: S-12572.patch)
> Reuse fieldvalues computed while sorting at writing in
[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554746#comment-16554746
]
Varun Thacker commented on SOLR-12587:
--
Here's a version of
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: S-12572.patch
> Reuse fieldvalues computed while sorting at writing in ExportWriter
>
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554740#comment-16554740
]
ASF subversion and git services commented on SOLR-11598:
Commit
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554741#comment-16554741
]
ASF subversion and git services commented on SOLR-11598:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554736#comment-16554736
]
Amrit Sarkar edited comment on SOLR-12572 at 7/24/18 8:06 PM:
--
Thanks Varun;
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554736#comment-16554736
]
Amrit Sarkar commented on SOLR-12572:
-
Thanks Varun; great insights. I am able to put up a patch
[
https://issues.apache.org/jira/browse/SOLR-12572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amrit Sarkar updated SOLR-12572:
Attachment: S-12572.patch
> Reuse fieldvalues computed while sorting at writing in ExportWriter
>
[
https://issues.apache.org/jira/browse/SOLR-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man resolved SOLR-12567.
-
Resolution: Fixed
Fix Version/s: 7.5
master (8.0)
> Enhance JSON Facet
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Windows/712/
Java: 64bit/jdk-11-ea+23 -XX:+UseCompressedOops -XX:+UseSerialGC
12 tests failed.
FAILED:
org.apache.solr.cloud.TestMiniSolrCloudClusterSSL.testSslWithCheckPeerName
Error Message:
Could not find collection:first_collection
[
https://issues.apache.org/jira/browse/LUCENE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554714#comment-16554714
]
Michael Braun commented on LUCENE-8426:
---
This would be useful to us!
> Make ConjunctionSpans
[
https://issues.apache.org/jira/browse/SOLR-12561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554707#comment-16554707
]
Lucene/Solr QA commented on SOLR-12561:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554705#comment-16554705
]
Varun Thacker commented on SOLR-11598:
--
I found another reproducible test failure while beasting
Jerry Bao created SOLR-12588:
Summary: Solr Autoscaling History doesn't log node added events
Key: SOLR-12588
URL: https://issues.apache.org/jira/browse/SOLR-12588
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554688#comment-16554688
]
Varun Thacker commented on SOLR-12587:
--
Hi [~joel.bernstein]
I'm trying to understand why we need
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Linux/2407/
Java: 64bit/jdk1.8.0_172 -XX:-UseCompressedOops -XX:+UseSerialGC
All tests passed
Build Log:
[...truncated 60507 lines...]
-ecj-javadoc-lint-tests:
[mkdir] Created dir: /tmp/ecj68250492
[ecj-lint] Compiling 922 source files
Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2619/
1 tests failed.
FAILED: org.apache.solr.cloud.MultiThreadedOCPTest.test
Error Message:
Task 2 did not complete, final state: RUNNING expected same: was
not:
Stack Trace:
java.lang.AssertionError: Task 2 did not complete,
[
https://issues.apache.org/jira/browse/SOLR-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett resolved SOLR-12576.
--
Resolution: Fixed
Fix Version/s: 7.5
Looks good - thanks. I resolved this.
>
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554654#comment-16554654
]
Varun Thacker commented on SOLR-11598:
--
Ughh. Sorry for that Hoss!
I had found that when running
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554647#comment-16554647
]
ASF subversion and git services commented on SOLR-11598:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554648#comment-16554648
]
ASF subversion and git services commented on SOLR-12567:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554646#comment-16554646
]
ASF subversion and git services commented on SOLR-12567:
Commit
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204862363
--- Diff: solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java
---
@@ -58,14 +59,13 @@ public void test() throws Exception {
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204861300
--- Diff:
solr/core/src/java/org/apache/solr/cloud/api/collections/TimeRoutedAlias.java
---
@@ -126,6 +128,7 @@ public static String
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204860462
--- Diff: solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java ---
@@ -150,15 +150,13 @@ public void testBasic() throws Exception {
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204858823
--- Diff: solr/core/src/test/org/apache/solr/TestDistributedSearch.java ---
@@ -910,13 +910,11 @@ public void test() throws Exception {
Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/425#discussion_r204858410
--- Diff: solr/core/src/test/org/apache/solr/TestDistributedSearch.java ---
@@ -910,13 +910,11 @@ public void test() throws Exception {
Varun Thacker created SOLR-12587:
Summary: Reuse Lucene's PriorityQueue for the ExportHandler
Key: SOLR-12587
URL: https://issues.apache.org/jira/browse/SOLR-12587
Project: Solr
Issue Type:
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Windows/7444/
Java: 64bit/jdk-10.0.1 -XX:+UseCompressedOops -XX:+UseSerialGC
14 tests failed.
FAILED:
org.apache.solr.cloud.autoscaling.AutoAddReplicasIntegrationTest.testSimple
Error Message:
Error from server at
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/22517/
Java: 64bit/jdk-10 -XX:+UseCompressedOops -XX:+UseG1GC
1 tests failed.
FAILED: org.apache.solr.cloud.autoscaling.ComputePlanActionTest.testNodeLost
Error Message:
org.apache.solr.common.SolrException:
Stack Trace:
[
https://issues.apache.org/jira/browse/LUCENE-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554564#comment-16554564
]
David Smiley commented on LUCENE-8426:
--
I'm not sure what the semantics of a protected class might
Hari Menon created LUCENE-8426:
--
Summary: Make ConjunctionSpans protected/public
Key: LUCENE-8426
URL: https://issues.apache.org/jira/browse/LUCENE-8426
Project: Lucene - Core
Issue Type:
Cool, created https://issues.apache.org/jira/browse/LUCENE-8426
On Mon, Jul 23, 2018 at 7:40 PM David Smiley
wrote:
> Hi,
>
> Please file an issue. I'm sympathetic to this -- I have also wound up
> copying ConjunctionSpans in a search app that had some custom Spans.
>
> ~ David
>
> On Mon, Jul
[
https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554549#comment-16554549
]
ASF subversion and git services commented on LUCENE-8414:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554552#comment-16554552
]
Nhat Nguyen commented on LUCENE-8414:
-
Thanks [~simonw]. I committed and backported to 7x.
> CI
[
https://issues.apache.org/jira/browse/LUCENE-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554508#comment-16554508
]
ASF subversion and git services commented on LUCENE-8414:
-
Commit
David Smiley created SOLR-12586:
---
Summary: Replace use of Joda Time with Java 8 java.time
Key: SOLR-12586
URL: https://issues.apache.org/jira/browse/SOLR-12586
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554471#comment-16554471
]
Adrien Grand commented on LUCENE-8421:
--
Sorry I should have provided more context. I agree this
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204819121
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -322,6 +327,59 @@ public void
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204818612
--- Diff:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateAliasCmd.java ---
@@ -136,6 +139,16 @@ private Instant parseStart(String str,
[
https://issues.apache.org/jira/browse/SOLR-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated SOLR-11598:
-
Affects Version/s: (was: 6.6.1)
(was: 7.0)
> Export Writer needs
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204814239
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204813287
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204813187
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Build: https://builds.apache.org/job/Lucene-Solr-Tests-7.x/697/
2 tests failed.
FAILED:
org.apache.solr.cloud.autoscaling.sim.TestTriggerIntegration.testNodeLostTriggerRestoreState
Error Message:
The trigger did not fire at all
Stack Trace:
java.lang.AssertionError: The trigger did not fire
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204802880
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Build: https://jenkins.thetaphi.de/job/Lucene-Solr-7.x-Solaris/743/
Java: 64bit/jdk1.8.0 -XX:-UseCompressedOops -XX:+UseConcMarkSweepGC
1 tests failed.
FAILED:
org.apache.solr.handler.component.InfixSuggestersTest.testShutdownDuringBuild
Error Message:
junit.framework.AssertionFailedError:
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204787481
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204786129
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -70,7 +78,8 @@ public DocTransformer
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204785843
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -61,6 +65,10 @@
*/
public class
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204785508
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/LUCENE-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554320#comment-16554320
]
Adrien Grand commented on LUCENE-8425:
--
I wish we didn't have to make SegmentReader constructors
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204777468
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -61,6 +65,10 @@
*/
public class
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204776145
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -70,7 +78,8 @@ public DocTransformer
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204775739
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed
Github user moshebla commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204774918
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml ---
@@ -567,7 +567,17 @@
-
+
--- End diff
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204766704
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204772998
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204768647
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204772658
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204762445
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -61,6 +65,10 @@
*/
public class
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204769700
--- Diff: solr/core/src/test-files/solr/collection1/conf/schema15.xml ---
@@ -567,7 +567,17 @@
-
+
--- End diff
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204764287
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -91,15 +100,37 @@ public DocTransformer
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204771149
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestDeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,163 @@
+/*
+ *
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204765898
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r204763476
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
---
@@ -70,7 +78,8 @@ public DocTransformer
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204764304
--- Diff:
solr/core/src/java/org/apache/solr/cloud/api/collections/TimeRoutedAlias.java
---
@@ -126,6 +128,7 @@ public static String
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204762784
--- Diff:
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
---
@@ -322,6 +327,59 @@ public void
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/416
I added a new test
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204761178
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -405,4 +454,56 @@ protected void doClose() {
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/416
RE isAtomicUpdate: Good catch! Please add a test to call this; perhaps
it's just one additional line to an existing test.
---
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204758735
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -230,6 +219,59 @@ public void
Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-master/1592/
3 tests failed.
FAILED:
org.apache.lucene.store.TestMockDirectoryWrapper.testThreadSafetyInListAll
Error Message:
Captured an uncaught exception in thread: Thread[id=876, name=Thread-821,
state=RUNNABLE,
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204757584
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -170,55 +179,35 @@ public void
Github user nsoft commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204756996
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -170,55 +179,35 @@ public void
1 - 100 of 129 matches
Mail list logo