Re: [VOTE] Release Lucene/Solr 8.4.0 RC2

2019-12-19 Thread Ignacio Vera
+1 SUCCESS! [1:25:57.302283] On Fri, Dec 20, 2019 at 12:23 AM Adrien Grand wrote: > Please vote for release candidate 2 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: > >

Re: New branch and feature freeze for Lucene/Solr 8.4.0

2019-12-19 Thread Adrien Grand
Hi Kevin, If you don't mind waiting a bit, that will make things easier. Otherwise we'd need to add the 8.4.1 version to the changelog for this change, and this would be in the way of a new RC, would we need to do another one. On Fri, Dec 20, 2019 at 5:24 AM Kevin Risden wrote: > Adrien -

Re: New branch and feature freeze for Lucene/Solr 8.4.0

2019-12-19 Thread Kevin Risden
Adrien - there is a bug fix for Solr and TLS clientAuth - https://issues.apache.org/jira/browse/SOLR-14106. Based on the comments there don't think its required to respin 8.4.0. Is it ok to commit to branch_8_4 in case there is a need for a respin so it gets picked up? Otherwise I would expect it

Re: Jackson ObjectMapper reuse

2019-12-19 Thread Noble Paul
SolrJacksonAnnotationInspector is OK, because it is created and given to the original caller who creates it. The caller is supposed to cache and reuse it On Fri, Dec 20, 2019 at 4:41 AM Ishan Chattopadhyaya wrote: > > Thanks Colvin for the analysis. Very helpful! > > I added the one here: >

[VOTE] Release Lucene/Solr 8.4.0 RC2

2019-12-19 Thread Adrien Grand
Please vote for release candidate 2 for Lucene/Solr 8.4.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC2-revbc02ab906445fcf4e297f4ef00ab4a54fdd72ca2 You can run the smoke tester directly with this command: python3 -u

Re: [jira] [Commented] (SOLR-13778) Windows JDK SSL Test Failure trend: SSLException: Software caused connection abort: recv failed

2019-12-19 Thread Chris Hostetter
If we were in a movie, now is when Dawid would be suddenly and unexpectedly be targetted by assassins. : Date: Thu, 19 Dec 2019 21:38:00 + (UTC) : From: "Dawid Weiss (Jira)" : To: hoss...@apache.org : Subject: [jira] [Commented] (SOLR-13778) Windows JDK SSL Test Failure trend: :

Re: Jackson ObjectMapper reuse

2019-12-19 Thread Ishan Chattopadhyaya
Thanks Colvin for the analysis. Very helpful! I added the one here: org.apache.solr.packagemanager.PackageUtils.getMapper() Now, that you mentioned, I'll change it to reuse it. However, this particular one is not performance critical as it is called from the SolrCLI (when "bin/solr package"

Jackson ObjectMapper reuse

2019-12-19 Thread Colvin Cowie
Hi, Looking through the source code to check up on a vulnerability in Jackson, I saw that there's a couple of places on master where new *ObjectMapper*s are being created and not reused. I've found through experience that not reusing ObjectMappers (especially in loops) can have a very

SIP for solr log and thread indexing and an associated UI

2019-12-19 Thread Erick Erickson
https://cwiki.apache.org/confluence/display/SOLR/SIP-3+Solr-specific+log+and+thread+indexing+and+UI https://issues.apache.org/jira/browse/SOLR-14121 I’ll add the link to the e-mail discussion to the SIP when this message gets there….

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-19 Thread Adrien Grand
It's taking some time because the first build of RC2 found a test failure in TestWandScorer that looks like a real bug. I'm digging it. On Thu, Dec 19, 2019 at 8:52 AM Ignacio Vera wrote: > I have spoken to Adrien offline and I have included LUCENE-90555 which > includes a fix where shape line