Re: [GitHub] [lucene-solr] uschindler commented on pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

2021-02-14 Thread Michael Sokolov
So sorry to hear that Uwe; take your time to grieve - that's a big one, I think -Mike On Sat, Feb 13, 2021 at 9:57 AM GitBox wrote: > > > uschindler commented on pull request #2306: > URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-778630343 > > >> @uschindler if you want

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Walter Underwood
Rate limiting is a good idea. It requires a lot of ongoing engineering to adjust the rates to the current cluster behavior. It doesn’t help with some kinds of overload. The ROI just doesn’t work out. It is too much work for not enough benefit. Rate limiting works if the collection size doesn’t

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Atri Sharma
This is a debate better suited for a different forum -- but I would disagree with your assertion that rate limiting is a bad idea. Solr allows you to specify node level request quotas which also follow the principle of not limiting internal requests. I find that to be pretty useful in two

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Walter Underwood
We’ve looked at and rejected rate limiters as high-maintenance and not sufficient protection. We would have run nginx on each node, sent external traffic to nginx on a different port and let internal traffic stay on the default Solr port. This has other advantages (monitoring), but the rate

Re: Circuit Breaker Clean-up/Extension Jira

2021-02-14 Thread Atri Sharma
If you have a github account, you can fork Lucene/Solr repository, create a branch in your fork, push your changes there and navigate to the Github page of your fork which will provide you a button to create a PR. On Sun, 14 Feb 2021, 23:46 Walter Underwood, wrote: > Sorry, couldn’t figure out

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Atri Sharma
The way I look at it is that for cluster level stability, rate limiters should be used which allow rate limiting of only external requests. They are "circuit breakers" in the sense of defending against cluster level instability, which is what you describe. Circuit breakers, in Solr world, are

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Walter Underwood
Ideally, it would only affect a few queries. In reality, with a sharded system, the impact will be large. I disagree that the goal is to protect a node. The goal is to make the entire cluster avoid congestion failure when overloaded, while providing good service for the load that it can

Re: Circuit Breaker Clean-up/Extension Jira

2021-02-14 Thread Walter Underwood
Sorry, couldn’t figure out how to do that for Solr. I do PRs all day on our company system, but that uses Bitbucket. The “how to contribute” docs just said to make a PR, which didn’t really help. I tried, but nothing worked. wunder Walter Underwood wun...@wunderwood.org

Re: Circuit Breaker Clean-up/Extension Jira

2021-02-14 Thread Atri Sharma
Also, if you could open a PR, it would be easier to review. On Sun, 14 Feb 2021, 23:22 Atri Sharma, wrote: > Apologies for the delay. I will review this tomorrow > > On Sun, 14 Feb 2021, 23:06 Walter Underwood, > wrote: > >> Please review for 8.9. We will use this feature after it is updated.

Re: Circuit Breaker Clean-up/Extension Jira

2021-02-14 Thread Atri Sharma
Apologies for the delay. I will review this tomorrow On Sun, 14 Feb 2021, 23:06 Walter Underwood, wrote: > Please review for 8.9. We will use this feature after it is updated. The > current circuit breakers won’t work for us. > > https://issues.apache.org/jira/browse/SOLR-15056 > > This change:

Re: Circuit Breakers interaction with Shards

2021-02-14 Thread Atri Sharma
This has an issue of still leading to node outages if the fanout for a query is high. Circuit breakers follow a simple rule -- defend the node at the cost of degraded responses. Ideally, only few requests will be completely rejected -- some will see partial results. Due to this non

Circuit Breakers interaction with Shards

2021-02-14 Thread Walter Underwood
This got zero responses on the solr-user list, so I’ll raise the issue here. Should circuit breakers only kill external search requests and not cluster-internal requests to shards? Circuit breakers can kill any request, whether it is a client request from outside the cluster or an internal

Circuit Breaker Clean-up/Extension Jira

2021-02-14 Thread Walter Underwood
Please review for 8.9. We will use this feature after it is updated. The current circuit breakers won’t work for us. https://issues.apache.org/jira/browse/SOLR-15056 This change: * Preserves existing functionality. * Renames the existing load average circuit breaker to a more accurate name. *

Re: [VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-14 Thread Timothy Potter
Looks like an extra space got added on the end of the python3 command, try this one: python3 -u dev-tools/scripts/smokeTestRelease.py https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.1-RC1-rev6a50a0315ac7e4979abb0b530857c7795bb3b928 On Sun, Feb 14, 2021 at 9:26 AM Timothy Potter

[VOTE] Release Lucene/Solr 8.8.1 RC1

2021-02-14 Thread Timothy Potter
Please vote for release candidate 1 for Lucene/Solr 8.8.1 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.1-RC1-rev6a50a0315ac7e4979abb0b530857c7795bb3b928 You can run the smoke tester directly with this command: python3 -u