Re: [VOTE] Release Lucene/Solr 8.10.1 RC1

2021-10-14 Thread Namgyu Kim
+1 SUCCESS! [1:00:57.143976] On Fri, Oct 15, 2021 at 1:05 AM Houston Putman wrote: > +1 SUCCESS! [1:05:55.854939] > > On Thu, Oct 14, 2021 at 9:29 AM Michael Gibney > wrote: > >> +1 SUCCESS! [1:00:31.099832] >> >> On Thu, Oct 14, 2021 at 7:42 AM Ignacio Vera wrote: >> >>> +1 >>> >>> SUCCESS! [

Re: Accessibility of CollectedSearchGroup's state

2021-10-14 Thread jim ferenczi
I agree, we should have a SinglePassGroupingCollector in Elasticsearch and reduce the visibility of these expert classes in Lucene. As it stands today, the FirstPassGroupingCollector could be a final class imo. Le jeu. 14 oct. 2021 à 18:42, Adrien Grand a écrit : > I feel sorry for increasing t

Re: Accessibility of CollectedSearchGroup's state

2021-10-14 Thread Adrien Grand
I feel sorry for increasing the scope of all these requests for changes that you make, but the way Elasticsearch overrides this collector feels wrong to me as any change in the implementation details of this collector would probably break Elasticsearch's collector too. In my opinion, CollectedSearc

Re: [VOTE] Release Lucene/Solr 8.10.1 RC1

2021-10-14 Thread Houston Putman
+1 SUCCESS! [1:05:55.854939] On Thu, Oct 14, 2021 at 9:29 AM Michael Gibney wrote: > +1 SUCCESS! [1:00:31.099832] > > On Thu, Oct 14, 2021 at 7:42 AM Ignacio Vera wrote: > >> +1 >> >> SUCCESS! [1:01:50.808390] >> >> On Thu, Oct 14, 2021 at 1:40 PM Michael McCandless < >> luc...@mikemccandless.c

Re: [VOTE] Release Lucene/Solr 8.10.1 RC1

2021-10-14 Thread Michael Gibney
+1 SUCCESS! [1:00:31.099832] On Thu, Oct 14, 2021 at 7:42 AM Ignacio Vera wrote: > +1 > > SUCCESS! [1:01:50.808390] > > On Thu, Oct 14, 2021 at 1:40 PM Michael McCandless < > luc...@mikemccandless.com> wrote: > >> +1 >> >> >> SUCCESS! [0:44:35.590557] >> >> >> Mike McCandless >> >> http://blog.m

Accessibility of CollectedSearchGroup's state

2021-10-14 Thread Chris Hegarty
In an effort to prepare Elasticsearch for modularization, we are investigating and eliminating split packages. The situation has improved through recent refactoring in Lucene 9.0 [1], but a number of split packages still remain. This message identifies one such so that it can be discussed in isolat

Re: [VOTE] Release Lucene/Solr 8.10.1 RC1

2021-10-14 Thread Ignacio Vera
+1 SUCCESS! [1:01:50.808390] On Thu, Oct 14, 2021 at 1:40 PM Michael McCandless < luc...@mikemccandless.com> wrote: > +1 > > > SUCCESS! [0:44:35.590557] > > > Mike McCandless > > http://blog.mikemccandless.com > > > On Tue, Oct 12, 2021 at 8:00 PM Mayya Sharipova wrote: > >> Please vote for rel

Re: [VOTE] Release Lucene/Solr 8.10.1 RC1

2021-10-14 Thread Michael McCandless
+1 SUCCESS! [0:44:35.590557] Mike McCandless http://blog.mikemccandless.com On Tue, Oct 12, 2021 at 8:00 PM Mayya Sharipova wrote: > Please vote for release candidate 1 for Lucene/Solr 8.10.1 > > The artifacts can be downloaded from: > > https://dist.apache.org/repos/dist/dev/lucene/lucene