Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Atri Sharma
+1 SUCCESS! [0:22:43.58483] On Sat, Nov 27, 2021 at 8:30 PM Robert Muir wrote: > > +1 > > (with --test-java17) > SUCCESS! [0:26:01.193203] > > On Sat, Nov 27, 2021 at 8:40 AM Michael McCandless > wrote: > > > > +1 > > > > SUCCESS! [0:06:46.020662] > > > > What a crazy speedup to smoke tester!! >

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> Also fine with some note that, if you want to fork lucene and make your > own source release, you can use our packaging build infrastructure, but you > need to git clone. We are giving you a source release, not a git clone > (shallow or deep). If you want to fork and make your own customized sour

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 6:24 PM Uwe Schindler wrote: > FYI, > > looks like this: > > > > I also tried to compile, test and assemble. All works. Only the src.tgz > can’t be built from itsself, because the extracted folder is no git > repository 😊: > > > > > Task :checkWorkingCopyClean > > WARNING:

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
FYI, looks like this: I also tried to compile, test and assemble. All works. Only the src.tgz can’t be built from itsself, because the extracted folder is no git repository 😊: > Task :checkWorkingCopyClean WARNING: Directory is not a valid git checkout (won't check dirty files): C:\Us

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
The pax file is only in the root of the tar file next to the folder named "lucene-9.0.0/". This is why I have seen it. You open the tar file and it shows up next to the root folder, so it was impossible to ignore. Same after extraction. Am 28. November 2021 20:58:52 UTC schrieb Robert Muir : >O

Re: Warnings from gradle rat task

2021-11-28 Thread Martin Gainty
its been my experience gradle takes months to address these type of issues can be quite frustrating since people seem to be pushing gradle as build-du-jour martin- From: Mike Drob Sent: Saturday, November 27, 2021 11:20 AM To: dev@lucene.apache.org Subject: Re:

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 11:12 AM Uwe Schindler wrote: > > Thanks Robert! > > This is of course not a problem, but 7zip is the defacto unzipper used on > windows nowadays, so we should be prepared because of questions. > > It's not an issue at all, the hidden file contains useful information (comm

RE: simplifying precommit checks / GH actions

2021-11-28 Thread Uwe Schindler
Hi, > > OK, I see. I was thinking that a simple 'gradle check' as the github > > action would be easier to understand / reproduce locally for > > contributors, and that by combining the two tasks into one, we'd use > > less server-side resources (I have no idea what the limits are here, > > It d

Re: simplifying precommit checks / GH actions

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 12:37 PM Dawid Weiss wrote: > > > OK, I see. I was thinking that a simple 'gradle check' as the github > > action would be easier to understand / reproduce locally for > > contributors, and that by combining the two tasks into one, we'd use > > less server-side resources (I

Re: simplifying precommit checks / GH actions

2021-11-28 Thread Dawid Weiss
> OK, I see. I was thinking that a simple 'gradle check' as the github > action would be easier to understand / reproduce locally for > contributors, and that by combining the two tasks into one, we'd use > less server-side resources (I have no idea what the limits are here, It does use more resou

Re: simplifying precommit checks / GH actions

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 11:34 AM Dawid Weiss wrote: > > Hi Robert, > > > * gradle check -x test: 8 minutes, 15 seconds > > * gradle test: 9 minutes, 8 seconds > > These are done in parallel on separate VMs - if we merge them the > combined time will be longer (that's why I split them into two > st

Re: simplifying precommit checks / GH actions

2021-11-28 Thread Dawid Weiss
Hi Robert, > * gradle check -x test: 8 minutes, 15 seconds > * gradle test: 9 minutes, 8 seconds These are done in parallel on separate VMs - if we merge them the combined time will be longer (that's why I split them into two stages). > * lift: 84 minutes This is some sonatype static checker/ b

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
Thanks Robert! This is of course not a problem, but 7zip is the defacto unzipper used on windows nowadays, so we should be prepared because of questions. It's not an issue at all, the hidden file contains useful information (commit hash), so I don't care. I was more wondering why it was created

simplifying precommit checks / GH actions

2021-11-28 Thread Robert Muir
Hello, Currently we run 3 actions on every PR/update. I'm including sample runtimes from the most recent PR: https://github.com/apache/lucene/pull/478 * gradle check -x test: 8 minutes, 15 seconds * gradle test: 9 minutes, 8 seconds * lift: 84 minutes First question: should we combine the first

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
https://sourceforge.net/p/sevenzip/bugs/2116/ Basically, it seems to me this 7zip doesn't support the posix pax extensions used by lots of software (read the comments on the bug report for an idea). So it treats them as ordinary tar files and that's why Uwe sees these files. On Sun, Nov 28, 2021

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 5:15 AM Dawid Weiss wrote: >> >> >> Wasn't the src.tgz not created by Gradle? Was it done by using the git >> command line inside the release wizard? > > > No - we use external git because it simplifies excludes/ includes (git will > only compress versioned files). > http

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> > > Wasn't the src.tgz not created by Gradle? Was it done by using the git > command line inside the release wizard? > No - we use external git because it simplifies excludes/ includes (git will only compress versioned files). https://github.com/apache/lucene/blob/main/lucene/distribution/source

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
I found that out, too. Wasn't the src.tgz not created by Gradle? Was it done by using the git command line inside the release wizard? I used 7zip on Windows to review file contents. Uwe Am 28. November 2021 08:29:55 UTC schrieb Dawid Weiss : >> >> I checked the src.tgz file, I was only a bit c

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> > I checked the src.tgz file, I was only a bit confused about the > "pax_global_header" file, looks as if it contains the commit hash. What's > this? > Seems like a file created by git export - Kernel tar-archives created by git contain an extended header with the git commit ID that was used to