Re: Mirroring the later 8.x release tags in the "new" split repositories

> I did mean that we should be pushing the tags as well as their associated > commits. > You can even edit them by hand so you can definitely have references pointing at void... I already expressed my opinion on the matter but I won't object if you wish to do it. The problem I see is that it's

Re: Mirroring the later 8.x release tags in the "new" split repositories

+1 to Houston's proposal. Given all the release tags seen here: https://github.com/apache/solr/tags it makes sense that it would include the tag for 8.11 and the others we're missing. I think this is a really easy decision as it's weird/inconsistent that these particular versions are omitted yet

Re: Mirroring the later 8.x release tags in the "new" split repositories

Dawid, I did mean that we should be pushing the tags as well as their associated commits. I was unaware that you could push the tags without the commits, sorry if I caused confusion there. Jan, Looking in the diff between the "history/branches/lucene-solr/branch_8x" tag in apache/solr and the

Re: Mirroring the later 8.x release tags in the "new" split repositories

> You can push a tag to a repo that doesn't already have that commit (or > history of commits) in an existing branch, without issue. But why do it? These are refs - if they point to non-existing commits then I honestly don't see any value in having them. It would confuse the hell out of me. >

Re: Mirroring the later 8.x release tags in the "new" split repositories

They don't have those commits, but they also don't have the commits for the previous release tags in the repo. You can go to any of the release tags, choose a commit to view and you will get a message saying: > This commit does not belong to any branch on this repository, > and may belong to a

Re: Mirroring the later 8.x release tags in the "new" split repositories

> As mentioned in SOLR-15874, we are not hosting the tags for the latest 8.x > releases in the split apache/solr and apache/lucene repositories. All release > tags made prior to the repository split exist in the new repos, so I see no > reason that the newer 8.x tags cannot exist in the new

Re: issue with modules while building PyLucene

For the record - that module-info.class isn't really needed since Lucene is designed to work fine in classpath mode anyway (and in classpath mode the module info is ignored too). On Tue, Jan 4, 2022 at 7:52 PM Andi Vajda wrote: > > On Tue, 4 Jan 2022, Dawid Weiss wrote: > > > You have to

Re: issue with modules while building PyLucene

On Tue, 4 Jan 2022, Andi Vajda wrote: On Tue, 4 Jan 2022, Dawid Weiss wrote: You have to exclude that module-info.class from processing somehow, Andi. It isn't a proper class indeed. Can jcc accept an exclusion pattern somehow? Oh yes, that's not a problem, just add it via --exclude,

Re: Mirroring the later 8.x release tags in the "new" split repositories

I think mirroring the tags is a good idea and can only be useful. On Tue, Jan 4, 2022 at 8:56 AM Houston Putman wrote: > Hello all, > > As mentioned in SOLR-15874 > , we are not hosting > the tags for the latest 8.x releases in the split

Re: issue with modules while building PyLucene

On Tue, 4 Jan 2022, Dawid Weiss wrote: You have to exclude that module-info.class from processing somehow, Andi. It isn't a proper class indeed. Can jcc accept an exclusion pattern somehow? Oh yes, that's not a problem, just add it via --exclude, let me try that and report back. Andi..

Re: issue with modules while building PyLucene

You have to exclude that module-info.class from processing somehow, Andi. It isn't a proper class indeed. Can jcc accept an exclusion pattern somehow? Dawid On Tue, Jan 4, 2022 at 7:36 PM Andi Vajda wrote: > > Hi, > > I was able to build PyLucene with Lucene 9.0 and have it pass all its >

issue with modules while building PyLucene

Hi, I was able to build PyLucene with Lucene 9.0 and have it pass all its tests. Now, I moved to branch_9x (to get access to the new collectRuntimeJars Gradle task) and I'm hitting an issue that seems to be related to the new work around java modules: Exception in thread "main"

Re: where is the antlr4 runtime jar ?

On Mon, 3 Jan 2022, Dawid Weiss wrote: I've applied it to branch_9x and main, Andi. Thank you, Dawid, I was able to get PyLucene to build and all its tests to pass with this code added to Lucene 9.0 from Lucene 9.x. Andi.. D. On Mon, Jan 3, 2022 at 6:34 PM Andi Vajda wrote: On

Mirroring the later 8.x release tags in the "new" split repositories

Hello all, As mentioned in SOLR-15874 , we are not hosting the tags for the latest 8.x releases in the split apache/solr and apache/lucene repositories. All release tags made prior to the repository split exist in the new repos, so I see no reason

Re: Heads up: module system integration

I made a quick summary of the state of the module system support here. https://issues.apache.org/jira/browse/LUCENE-10328?focusedCommentId=17468676=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17468676 I plan to un-draft the PR and commit it back to main as it