Re: Running tests with streaming console output but NOT verbose?

2023-12-12 Thread Dawid Weiss
I think I remember now... So, this is LuceneTestCase: /** * True if and only if tests are run in verbose mode. If this flag is false tests are not expected * to print any messages. Enforced with {@link TestRuleLimitSysouts}. */ public static final boolean VERBOSE = systemPropertyAsBoo

Re: Running tests with streaming console output but NOT verbose?

2023-12-12 Thread Michael McCandless
Ahh thanks for the quick explanation and temporary solution Dawid!. Naming is the hardest part :) I think long ago we used to call it "-Dtests.stdout=true" or so? Not the greatest name tho. Maybe "tests.liveConsoleOut"? "tests.liveConsole"? Mike McCandless http://blog.mikemccandless.com On

Re: Running tests with streaming console output but NOT verbose?

2023-12-12 Thread Dawid Weiss
This is actually an accidental (?) clash between Lucene's system property and what's in defaults-tests.gradle. You can manually prepend true || ... to the following in defaults-tests.gradle. def verboseMode = resolvedTestOption("tests.verbose").toBoolean() I can't remember why it aligns with

Running tests with streaming console output but NOT verbose?

2023-12-12 Thread Michael McCandless
Hi Team, This is prolly a Dawid question... Sometimes I want to run a test (like a slow Monster test), seeing its ongoing musings popping out on the console in "real time" (not buffered). I can do this today by adding "-Dtests.verbose=true" to the ./gradlew invocation that's running the test. B

Re: The need for a Lucene 9.9.1 release

2023-12-12 Thread Michael McCandless
OK this is merged now. Are there any other 9.9.1 blockers? I am trying to pass all Monster tests but that can probably just run concurrently with voting (optimistic concurrency!)? Mike McCandless http://blog.mikemccandless.com On Tue, Dec 12, 2023 at 9:18 AM Chris Hegarty wrote: > Hi Mike,

Re: The need for a Lucene 9.9.1 release

2023-12-12 Thread Chris Hegarty
Hi Mike, > On 12 Dec 2023, at 12:56, Michael McCandless > wrote: > > Hi Chris, > > I think we should also regenerate the FSTs for 9.9.1? Seems reasonable. > https://github.com/apache/lucene/pull/12924 I added my comments and review on the PR. -Chris. > Thanks, > > Mike -

Re: The need for a Lucene 9.9.1 release

2023-12-12 Thread Michael McCandless
Hi Chris, I think we should also regenerate the FSTs for 9.9.1? https://github.com/apache/lucene/pull/12924 Thanks, Mike On Tue, Dec 12, 2023 at 7:54 AM Guo Feng wrote: > Heads up: > > The bug fix PR (https://github.com/apache/lucene/pull/12900) has been > merged to main, and backported

Re: The need for a Lucene 9.9.1 release

2023-12-12 Thread Guo Feng
Heads up: The bug fix PR (https://github.com/apache/lucene/pull/12900) has been merged to main, and backported to lucene_9x & lucene_9_9. On 2023/12/11 20:27:48 Chris Hegarty wrote: > Just a quick update on this... > > > On 9 Dec 2023, at 09:09, Chris Hegarty > > wrote: > > > > Hi, > > > >