[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768041#comment-13768041 ] Shai Erera commented on LUCENE-5215: It's ok that SWS contains fieldInfos - FieldsWri

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767887#comment-13767887 ] Shai Erera commented on LUCENE-5215: I started by creating a new Lucene46Codec and ma

[jira] [Commented] (LUCENE-5216) Fix SegmentInfo.attributes when updates are involved

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767867#comment-13767867 ] Shai Erera commented on LUCENE-5216: I searched for SI.attributes(), they aren't used

[jira] [Created] (LUCENE-5216) Fix SegmentInfo.attributes when updates are involved

2013-09-15 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5216: -- Summary: Fix SegmentInfo.attributes when updates are involved Key: LUCENE-5216 URL: https://issues.apache.org/jira/browse/LUCENE-5216 Project: Lucene - Core Issu

[jira] [Commented] (SOLR-4988) Upgrade svnkit to version compatible with svn 1.8

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767854#comment-13767854 ] Shai Erera commented on SOLR-4988: -- Thanks Alan! I see that 'precommit' runs 'documentati

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767853#comment-13767853 ] Shai Erera commented on LUCENE-5189: Thanks, committed to trunk, revision 1523461. Af

[jira] [Commented] (LUCENE-5215) Add support for FieldInfos generation

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767831#comment-13767831 ] Shai Erera commented on LUCENE-5215: Well, SI.attributes says it's the place for Code

[jira] [Created] (LUCENE-5215) Add support for FieldInfos generation

2013-09-15 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5215: -- Summary: Add support for FieldInfos generation Key: LUCENE-5215 URL: https://issues.apache.org/jira/browse/LUCENE-5215 Project: Lucene - Core Issue Type: New Fea

[jira] [Commented] (SOLR-4988) Upgrade svnkit to version compatible with svn 1.8

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767721#comment-13767721 ] Shai Erera commented on SOLR-4988: -- I see they now have a beta version available for downl

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Added some javadocs, converted all nocommits to TODOs. I think it's re

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Thanks Mike. Fixed the two ctors to call doClose {{if (!success)}}, as

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Fixed NRT support -- DVProducers moved from SegmentCoreReaders to Seg

[jira] [Commented] (SOLR-5241) SimplePostToolTest is slow on some systmes - likely due to hostname resolution of "example.com"

2013-09-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767367#comment-13767367 ] Shai Erera commented on SOLR-5241: -- Hoss, see my comments on the thread. Seems to be relat

[jira] [Commented] (SOLR-5241) SimplePostToolTest is slow on some systmes - likely due to hostname resolution of "example.com"

2013-09-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767351#comment-13767351 ] Shai Erera commented on SOLR-5241: -- This still runs fast, but a bit slower than with the p

[jira] [Commented] (SOLR-5241) SimplePostToolTest is slow on some systmes - likely due to hostname resolution of "example.com"

2013-09-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766874#comment-13766874 ] Shai Erera commented on SOLR-5241: -- With this patch, the test runs for 1.8-3.2s (varies, b

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch I've been busy hunting down concurrency bugs and making field updates

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758328#comment-13758328 ] Shai Erera commented on LUCENE-5189: Correct, that's a problem that Rob identified fe

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758311#comment-13758311 ] Shai Erera commented on LUCENE-5189: I think global FIS is an interesting idea, but p

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757921#comment-13757921 ] Shai Erera commented on LUCENE-5189: bq. It does not solve problem #2 (SegmentInfos.a

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757864#comment-13757864 ] Shai Erera commented on LUCENE-5189: Just so I understand, if we gen FieldInfos, does

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757688#comment-13757688 ] Shai Erera commented on LUCENE-5189: I think it's important to solve FIS.gen, either

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756931#comment-13756931 ] Shai Erera commented on LUCENE-5189: OK, so now I get your point. The problem is that

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756863#comment-13756863 ] Shai Erera commented on LUCENE-5189: I don't understand the problem that you raise. U

[jira] [Commented] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat used per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756757#comment-13756757 ] Shai Erera commented on LUCENE-5199: Thanks Rob! > Improve LuceneTes

[jira] [Commented] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat used per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756743#comment-13756743 ] Shai Erera commented on LUCENE-5199: Thanks Rob. I can commit it later, but feel free

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch improves RAM accounting in BufferedDeletes and FrozenBD. I added

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756650#comment-13756650 ] Shai Erera commented on LUCENE-5189: Thanks for the review Mike. I nuked the two unus

[jira] [Resolved] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat used per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5199. Resolution: Fixed Fix Version/s: 4.5 5.0 Committed to trunk and 4x.

[jira] [Updated] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat used per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5199: --- Summary: Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesForma

[jira] [Commented] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756555#comment-13756555 ] Shai Erera commented on LUCENE-5199: Core and Facet tests pass (only users of this AP

[jira] [Updated] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5199: --- Attachment: LUENE-5199.patch Added {{String... fields}} to LTC.defaultCodecSupportsDocsWithField and

[jira] [Commented] (LUCENE-5178) doc values should expose missing values (or allow configurable defaults)

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756551#comment-13756551 ] Shai Erera commented on LUCENE-5178: Opened LUCENE-5199. > doc value

[jira] [Created] (LUCENE-5199) Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field

2013-09-03 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5199: -- Summary: Improve LuceneTestCase.defaultCodecSupportsDocsWithField to check the actual DocValuesFormat in user per-field Key: LUCENE-5199 URL: https://issues.apache.org/jira/browse/LUC

[jira] [Commented] (LUCENE-5178) doc values should expose missing values (or allow configurable defaults)

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756536#comment-13756536 ] Shai Erera commented on LUCENE-5178: I see. I think this can also happen if you use R

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch adds per-field support. I currently do that by adding a boolean

[jira] [Commented] (LUCENE-5197) Add a method to SegmentReader to get the current index heap memory size

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756457#comment-13756457 ] Shai Erera commented on LUCENE-5197: bq. Wouldn't RamUsageEstimator (or its modificat

[jira] [Commented] (LUCENE-5178) doc values should expose missing values (or allow configurable defaults)

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756430#comment-13756430 ] Shai Erera commented on LUCENE-5178: I manage to reproduce it only if I set both test

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-09-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch adds testStressMultiThreading and testUpdateOldSegments to ensur

[jira] [Resolved] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

2013-09-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5196. Resolution: Fixed Fix Version/s: 4.5 5.0 Committed to trunk and 4x. For

[jira] [Commented] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

2013-08-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755451#comment-13755451 ] Shai Erera commented on LUCENE-5196: Maybe it's not so confusing. 41 supports writing

[jira] [Updated] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

2013-08-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5196: --- Attachment: LUCENE-5196.patch More formats respect impersonation. But with this 'ant test -Dtestca

[jira] [Updated] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

2013-08-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5196: --- Attachment: LUCENE-5196.patch Patch adds LuceneTestCase.OLD_FORMAT_IMPERSONATION_IS_ACTIVE, defaults

[jira] [Created] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE

2013-08-30 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5196: -- Summary: Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE Key: LUCENE-5196 URL: https://issues.apache.org/jira/browse/LUCENE-5196 Project: Lucene - Core Issue Type: Im

[jira] [Resolved] (LUCENE-5193) Add jar-src to build.xml

2013-08-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5193. Resolution: Fixed Fix Version/s: 4.5 5.0 Assignee: Shai Erera S

[jira] [Commented] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754604#comment-13754604 ] Shai Erera commented on LUCENE-5192: Thanks Mike for catching and fixing!!

[jira] [Commented] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754381#comment-13754381 ] Shai Erera commented on LUCENE-5192: Ahh that explains it. +1 to commit the synchroni

[jira] [Commented] (LUCENE-5193) Add jar-src to build.xml

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754347#comment-13754347 ] Shai Erera commented on LUCENE-5193: Looks good Steve. Feel free to commit. I'm not s

[jira] [Commented] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754040#comment-13754040 ] Shai Erera commented on LUCENE-5192: In that case it should change to: {code:java} i

[jira] [Commented] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754013#comment-13754013 ] Shai Erera commented on LUCENE-5192: Ahh, good catch. I didn't notice FieldNumbers is

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753600#comment-13753600 ] Shai Erera commented on LUCENE-5189: I definitely want to add update by query, but in

[jira] [Updated] (LUCENE-5193) Add jar-src to build.xml

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5193: --- Attachment: LUCENE-5193.patch Previous patch did not jar-src core and test-framework.

[jira] [Commented] (LUCENE-5193) Add jar-src to build.xml

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753579#comment-13753579 ] Shai Erera commented on LUCENE-5193: If there are no objections, I'll commit it later

[jira] [Updated] (LUCENE-5193) Add jar-src to build.xml

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5193: --- Attachment: LUCENE-5193.patch Simple patch for Lucene modules only, since they already support jar-s

[jira] [Created] (LUCENE-5193) Add jar-src to build.xml

2013-08-29 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5193: -- Summary: Add jar-src to build.xml Key: LUCENE-5193 URL: https://issues.apache.org/jira/browse/LUCENE-5193 Project: Lucene - Core Issue Type: New Feature

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753557#comment-13753557 ] Shai Erera commented on LUCENE-5189: Regarding problem 1, I hardwired the test to use

[jira] [Resolved] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5192. Resolution: Fixed Committed to trunk and 4x. On 4x I had to also fix DocFieldProcessor to call Fi

[jira] [Updated] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5192: --- Attachment: LUCENE-5192.patch Patch adds a testcase and fixes the bug. The bug only happens if you a

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753500#comment-13753500 ] Shai Erera commented on LUCENE-5189: Regarding problem 3, Mike helped me construct a

[jira] [Created] (LUCENE-5192) FieldInfos.Builder failed to catch adding field with different DV type under some circumstances

2013-08-29 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5192: -- Summary: FieldInfos.Builder failed to catch adding field with different DV type under some circumstances Key: LUCENE-5192 URL: https://issues.apache.org/jira/browse/LUCENE-5192

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753482#comment-13753482 ] Shai Erera commented on LUCENE-5189: BTW, this may generally not be a bad idea, to le

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753476#comment-13753476 ] Shai Erera commented on LUCENE-5189: Regarding problem 1, I don't know if it's a vali

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch adds some nocommits and tests that expose some problems: +Probl

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753312#comment-13753312 ] Shai Erera commented on LUCENE-5189: Thanks Rob. I forgot about SuppressCodecs :). I

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch addresses Rob's idea: * ReaderAndLiveDocs and SegCoreReaders se

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752456#comment-13752456 ] Shai Erera commented on LUCENE-5189: The problem is that there are two Directories an

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Rename fieldInfosGen to docValuesGen. I think I got all places fixed.

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752424#comment-13752424 ] Shai Erera commented on LUCENE-5189: bq. Can we refer to this consistently as docValu

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752409#comment-13752409 ] Shai Erera commented on LUCENE-5189: I forgot to mention -- this work started from a

[jira] [Updated] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5189: --- Attachment: LUCENE-5189.patch Patch adds numeric-dv field updates capabilities: * IndexWriter.updat

[jira] [Created] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5189: -- Summary: Numeric DocValues Updates Key: LUCENE-5189 URL: https://issues.apache.org/jira/browse/LUCENE-5189 Project: Lucene - Core Issue Type: New Feature

[jira] [Resolved] (LUCENE-5184) CountFacetRequest does not seem to sum the totals of the subResult values.

2013-08-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5184. Resolution: Not A Problem This is documented in OrdinalPolicy's enums. Perhaps it could have also

[jira] [Commented] (LUCENE-5166) PostingsHighlighter fails with IndexOutOfBoundsException

2013-08-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736784#comment-13736784 ] Shai Erera commented on LUCENE-5166: Interesting. FYI, I will not be available in the

[jira] [Commented] (LUCENE-5166) PostingsHighlighter fails with IndexOutOfBoundsException

2013-08-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736705#comment-13736705 ] Shai Erera commented on LUCENE-5166: Can you show a real usecase for a document match

[jira] [Commented] (LUCENE-4906) PostingsHighlighter's PassageFormatter should allow for rendering to arbitrary objects

2013-08-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734636#comment-13734636 ] Shai Erera commented on LUCENE-4906: I am not sure we should complicate the API? Perf

[jira] [Resolved] (LUCENE-5155) Add OrdinalValueResolver in favor of FacetRequest.getValueOf

2013-08-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5155. Resolution: Fixed Fix Version/s: 4.5 5.0 Thanks Gilad, added a comment a

[jira] [Updated] (LUCENE-5155) Add OrdinalValueResolver in favor of FacetRequest.getValueOf

2013-07-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5155: --- Attachment: LUCENE-5155.patch Patch addresses the proposed changes. All tests pass.

[jira] [Created] (LUCENE-5155) Add OrdinalValueResolver in favor of FacetRequest.getValueOf

2013-07-31 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5155: -- Summary: Add OrdinalValueResolver in favor of FacetRequest.getValueOf Key: LUCENE-5155 URL: https://issues.apache.org/jira/browse/LUCENE-5155 Project: Lucene - Core

[jira] [Resolved] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5153. Resolution: Fixed Fix Version/s: 4.5 5.0 Thanks Rob. I applied your impr

[jira] [Updated] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5153: --- Attachment: LUCENE-5153.patch Patch with discussed fixes and test. > Allow wrapping

[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724266#comment-13724266 ] Shai Erera commented on LUCENE-5153: bq. I dont see the test in the patch Hmm, I was

[jira] [Updated] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5153: --- Attachment: LUCENE-5153.patch Added a test to TestingAnalyzers which is under lucene/analysis/common

[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724119#comment-13724119 ] Shai Erera commented on LUCENE-5153: bq. I think this is the right thing? I tend to

[jira] [Commented] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723936#comment-13723936 ] Shai Erera commented on LUCENE-5153: If there are no objections, I'll commit it.

[jira] [Updated] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5153: --- Attachment: LUCENE-5153.patch simple patch > Allow wrapping Reader from AnalyzerWra

[jira] [Created] (LUCENE-5153) Allow wrapping Reader from AnalyzerWrapper

2013-07-30 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5153: -- Summary: Allow wrapping Reader from AnalyzerWrapper Key: LUCENE-5153 URL: https://issues.apache.org/jira/browse/LUCENE-5153 Project: Lucene - Core Issue Type: Ne

[jira] [Resolved] (LUCENE-5151) Associations aggregators enter an infinite loop if some documents have no category associations

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5151. Resolution: Fixed Fix Version/s: 4.5 5.0 Committed. > A

[jira] [Updated] (LUCENE-5151) Associations aggregators enter an infinite loop if some documents have no category associations

2013-07-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5151: --- Attachment: LUCENE-5151.patch Simple fix. I modified the test to insert some empty documents in the

[jira] [Created] (LUCENE-5151) Associations aggregators enter an infinite loop if some documents have no category associations

2013-07-30 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5151: -- Summary: Associations aggregators enter an infinite loop if some documents have no category associations Key: LUCENE-5151 URL: https://issues.apache.org/jira/browse/LUCENE-5151

[jira] [Resolved] (LUCENE-5147) Consider returning a Map from FacetsAccumulator

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5147. Resolution: Won't Fix I started to do it, but this has a large impact on tests. I don't see how mu

[jira] [Resolved] (LUCENE-5144) Nuke FacetRequest.createAggregator

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5144. Resolution: Fixed Thanks Hoss and Rob. Sorry for letting this nocommit slip through. I removed th

[jira] [Resolved] (LUCENE-5144) Nuke FacetRequest.createAggregator

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5144. Resolution: Fixed Fix Version/s: 4.5 5.0 Committed to trunk and 4x.

[jira] [Commented] (LUCENE-5144) Nuke FacetRequest.createAggregator

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722498#comment-13722498 ] Shai Erera commented on LUCENE-5144: Tests pass, if there are no objections, I intend

[jira] [Updated] (LUCENE-5144) Nuke FacetRequest.createAggregator

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5144: --- Attachment: LUCENE-5144.patch Patch removes FacetRequest.createAggregator (NOTE: *not* createFacets

[jira] [Created] (LUCENE-5147) Consider returning a Map from FacetsAccumulator

2013-07-29 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5147: -- Summary: Consider returning a Map from FacetsAccumulator Key: LUCENE-5147 URL: https://issues.apache.org/jira/browse/LUCENE-5147 Project: Lucene - Core Issue Ty

[jira] [Resolved] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-4985. Resolution: Fixed Assignee: Shai Erera Lucene Fields: New,Patch Available (was: Ne

[jira] [Commented] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722381#comment-13722381 ] Shai Erera commented on LUCENE-4985: bq. But, I think we should not document that "ra

[jira] [Updated] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-4985: --- Attachment: LUCENE-4985.patch Patch with fixed comments. > Make it easier to mix di

[jira] [Commented] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722375#comment-13722375 ] Shai Erera commented on LUCENE-4985: Adding State to .create() does not simplify life

[jira] [Updated] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests

2013-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-4985: --- Attachment: LUCENE-4985.patch Patch with --show-copies-as-adds > Make it easier to

[jira] [Created] (LUCENE-5144) Nuke FacetRequest.createAggregator

2013-07-29 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5144: -- Summary: Nuke FacetRequest.createAggregator Key: LUCENE-5144 URL: https://issues.apache.org/jira/browse/LUCENE-5144 Project: Lucene - Core Issue Type: Improvemen

<    5   6   7   8   9   10   11   12   13   14   >