Github user Timothy055 closed the pull request at:
https://github.com/apache/lucene-solr/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/107
I've made some more updates to the documentation for the pre and post
parameters as well as fixed the defaulting logic.
---
If your project is set up for it, you can reply to this email
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/107#discussion_r89227253
--- Diff:
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java ---
@@ -184,6 +185,20 @@ public void process(ResponseBuilder
Github user Timothy055 commented on the pull request:
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19911929
In
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
In
solr/core/src/java/org/apache
Github user Timothy055 commented on the pull request:
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19910515
In
solr/core/src/test/org/apache/solr/highlight/TestUnifiedSolrHighlighter.java:
In
solr/core/src/test/org/apache
Github user Timothy055 commented on the pull request:
https://github.com/apache/lucene-solr/commit/a62fba7a4ebdf7b46b12ef017fc89816ae709935#commitcomment-19910487
In
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java:
In
solr/core/src/java/org/apache
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Ah, missed that. Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Fair enough on both ends. And yes, we have seen a potential use case for a
unified view over terms. I'll take a look at MultiPostingsEnum and see if we
can use that.
---
If your project
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Merged your commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Forget it, you can't do that because the next position on one enum might be
-1, but there's more enums left in the queue so the user of this class could
inadvertently terminate early
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Hmm, I know we're already knowingly breaking the PostingsEnum contract, but
rather than throwing a IllegaStateException, maybe we could still return
positions, they just happen
GitHub user Timothy055 opened a pull request:
https://github.com/apache/lucene-solr/pull/107
SOLR-9708 UnifiedHighlighter Solr Plugin
An initial implementation of a solr plugin for the unified highlighter.
You can merge this pull request into a Git repository by running:
$ git
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
Hmm, clever! But not sure I find it very clean though. I feel like that
can lead to trouble down the road if code ever expects the offsets to be
ordered. If we went that route we wouldn't
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
I don't think there's a way to avoid keeping the position state,
unfortunately. The reason is that we can move one of the postings enums to the
next position, but then realize the next
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85619786
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85618489
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed
Github user Timothy055 commented on the issue:
https://github.com/apache/lucene-solr/pull/105
I've pushed some more changes now. Still taking a look at what we might be
able to do further with CompositePostingsEnum
---
If your project is set up for it, you can reply to this email
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85616894
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85616651
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85614277
--- Diff:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
---
@@ -79,7 +90,7
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85613814
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85613130
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
---
@@ -65,58 +65,88 @@ public String getField
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85612011
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/AnalysisOffsetStrategy.java
---
@@ -17,174 +17,28 @@
package
Github user Timothy055 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/105#discussion_r85611978
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/CompositePostingsEnum.java
---
@@ -0,0 +1,165 @@
+/*
+ * Licensed
GitHub user Timothy055 opened a pull request:
https://github.com/apache/lucene-solr/pull/105
LUCENE-7526 Improvements to UnifiedHighlighter OffsetStrategies
Pull request for LUCENE-7526
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Timothy055 closed the pull request at:
https://github.com/apache/lucene-solr/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user Timothy055 opened a pull request:
https://github.com/apache/lucene-solr/pull/79
LUCENE-7438 UnifiedHighlighter
Initial pull request for
[LUCENE-7438](https://issues.apache.org/jira/browse/LUCENE-7438)
You can merge this pull request into a Git repository by running
27 matches
Mail list logo
