[GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...

2018-10-30 Thread markrmiller
Github user markrmiller commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/486#discussion_r229525959 --- Diff: solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java --- @@ -265,10 +281,30 @@ public MiniSolrCloudCluster(int

[GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...

2018-10-30 Thread markrmiller
Github user markrmiller commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/486#discussion_r229525878 --- Diff: solr/core/src/test-files/solr/solr.xml --- @@ -40,12 +40,12 @@ 127.0.0.1 ${hostPort:8983} ${hostContext:solr

[GitHub] lucene-solr pull request #486: SOLR-12801: Fix the tests, remove BadApples a...

2018-10-30 Thread markrmiller
GitHub user markrmiller opened a pull request: https://github.com/apache/lucene-solr/pull/486 SOLR-12801: Fix the tests, remove BadApples and AwaitsFix annotations… …, improve env for test development. SOLR-12804: Remove static modifier from Overseer queue access

[GitHub] lucene-solr issue #34: Move hdfs stuff out into a new contrib

2016-08-31 Thread markrmiller
Github user markrmiller commented on the issue: https://github.com/apache/lucene-solr/pull/34 Sorry, still have the same objection. I am not really on board with this, "let's make core as slim as possible and put pressure on devs to not use libs." This is not Lucen

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-06 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217559403 We only have the needs of an hdfs client for shipping. I filed an issue to shrink that. Making a whole new contrib, extending the test running time, making

[GitHub] lucene-solr pull request: SOLR-8323

2016-05-05 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/32#issuecomment-217291207 > Although, thinking more about that, we already have a separate executor for watchers, don't we? Yes, every watch firing event should run f

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217233476 I filed https://issues.apache.org/jira/browse/SOLR-9075 to look at shrinking the hdfs client dependency jars. --- If your project is set up for it, you can

[GitHub] lucene-solr pull request: Move hdfs stuff out into a new contrib

2016-05-05 Thread markrmiller
Github user markrmiller commented on the pull request: https://github.com/apache/lucene-solr/pull/34#issuecomment-217231828 I'm not currently for this change. HDFS is currently built in and supported first class. I don't see a need to make anyone that wants to use it jump any more

IndexWriter.commit with IndexReader.reopen

2008-03-17 Thread markrmiller
I was playing around with LUCENE-831 last night and think I may have run into a bug? Can anyone verify that this should work? Open IndexWriter AddDocs Commit IndexWriter Open Reader SeeDocs AddNewDocs Commit IndexWriter ReopenReader SeeNewDocs I have not been able to SeeNewDocs. The