Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
I was thinking it is a bit more efficient, but I guess that small gain in
performance does not justify the exposure of a more internal API.
---
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/430
RE your last commit, why change `(String)null` to `(XML.Writeable)null`?
The latter exposes internal details/abstractions to a calling class that ought
not to care? (can simply change this
Github user dsmiley commented on the issue:
https://github.com/apache/lucene-solr/pull/430
This is looking really good Moshe; I'll commit later today after I do
precommit & tests
---
-
To unsubscribe, e-mail:
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
Hopefully your previous requests were addressed in these commits.
---
-
To unsubscribe, e-mail:
Github user moshebla commented on the issue:
https://github.com/apache/lucene-solr/pull/430
Hopefully the new method names are clear enough.
I naming is not one of my strong points. :worried:
---
-
To
