GitHub user susheelks opened a pull request:
https://github.com/apache/lucene-solr/pull/147
SOLR-8146 decouple building url list from CloudSolrClient to separate class
forâ¦
I am suggesting to decouple building the url list from
CloudSolrClient.sendRequest(..) to a separate class. The advantage will be the
ability to easily write unit test for building the url list part and as we
implement more routingRules for querying like query only the same rack
replica's / OR query replica's where mem/cpu/disk utilisation is below a
threshold can be easily unit tested etc.
I can add more tests if approach looks good. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/susheelks/lucene-solr SOLR-8146
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #147
----
commit 852aa685cc626a4a03c649895ae5ccbfb0008887
Author: Susheel Kumar <susheel2...@gmail.com>
Date: 2017-01-28T13:33:53Z
decouple building url list from CloudSolrClient to separate class for
better testability
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
