[GitHub] lucene-solr pull request #202: SOLR-10703 DocTransformer implements Closeabl...

2017-09-17 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r139309859 --- Diff: solr/solrj/src/java/org/apache/solr/common/util/IOUtils.java --- @@ -31,7 +32,7 @@ public static void closeQuietly(Closeable

[GitHub] lucene-solr pull request #202: SOLR-10703 DocTransformer implements Closeabl...

2017-09-06 Thread tflobbe
Github user tflobbe commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r137335651 --- Diff: solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java --- @@ -68,6 +69,51 @@ public void testCustomTransformer() throws

[GitHub] lucene-solr pull request #202: SOLR-10703 DocTransformer implements Closeabl...

2017-09-06 Thread tflobbe
Github user tflobbe commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r137335160 --- Diff: solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java --- @@ -68,6 +69,51 @@ public void testCustomTransformer() throws

[GitHub] lucene-solr pull request #202: SOLR-10703 DocTransformer implements Closeabl...

2017-09-06 Thread tflobbe
Github user tflobbe commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/202#discussion_r137335378 --- Diff: solr/core/src/test/org/apache/solr/response/TestCustomDocTransformer.java --- @@ -125,4 +171,86 @@ public static String getAsString(String