Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/317
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165576425
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165431325
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165375993
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/Passage.java ---
@@ -60,42 +65,35 @@ public void addMatch(int startOffset,
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165372379
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/OffsetsEnum.java
---
@@ -124,34 +123,122 @@ public PostingsEnum
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165370877
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldHighlighter.java
---
@@ -158,121 +143,58 @@ public Object
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/317#discussion_r165372488
--- Diff:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/Passage.java ---
@@ -193,8 +203,4 @@ public void setEndOffset(int endOffset)
GitHub user romseygeek opened a pull request:
https://github.com/apache/lucene-solr/pull/317
LUCENE-8145: OffsetsEnum is now unitary
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/romseygeek/lucene-solr offsetsenum
