[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-11 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r180669841 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-10 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r180628960 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r180496635 --- Diff: lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java --- @@ -151,6 +152,17 @@ public Explanation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r180494440 --- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java --- @@ -69,6 +69,24 @@ protected Weight(Query query) { */ public

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-10 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r180492694 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-07 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179913306 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestMatchesIterator.java --- @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-07 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179913304 --- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java --- @@ -69,6 +69,21 @@ protected Weight(Query query) { */ public

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179743866 --- Diff: lucene/core/src/test/org/apache/lucene/search/TestMatchesIterator.java --- @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179744351 --- Diff: lucene/core/src/java/org/apache/lucene/search/Weight.java --- @@ -69,6 +69,21 @@ protected Weight(Query query) { */ public

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179741828 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179742139 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179737921 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179737753 --- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java --- @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179742203 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179688171 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179680356 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179679658 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-06 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179679922 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179439888 --- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179442642 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179442549 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179443149 --- Diff: solr/core/src/java/org/apache/solr/update/DeleteByQueryWrapper.java --- @@ -77,6 +78,11 @@ public void extractTerms(Set terms) {

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179439647 --- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179442210 --- Diff: lucene/core/src/java/org/apache/lucene/search/DisjunctionMatchesIterator.java --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179442909 --- Diff: lucene/core/src/java/org/apache/lucene/search/MatchesIterator.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179439495 --- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179443767 --- Diff: lucene/core/src/java/org/apache/lucene/search/MatchAllDocsQuery.java --- @@ -35,6 +35,12 @@ public Weight createWeight(IndexSearcher

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-04-05 Thread jpountz
Github user jpountz commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/345#discussion_r179439321 --- Diff: lucene/core/src/java/org/apache/lucene/search/Matches.java --- @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] lucene-solr pull request #345: LUCENE-8229: Add Weight.matches() method

2018-03-28 Thread romseygeek
GitHub user romseygeek opened a pull request: https://github.com/apache/lucene-solr/pull/345 LUCENE-8229: Add Weight.matches() method This PR adds a method to Weight that allows iterating over the matching positions (and offsets if available) for a particular document and field.