[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-27 Thread moshebla
Github user moshebla closed the pull request at: https://github.com/apache/lucene-solr/pull/382 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-24 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190546131 --- Diff: solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java --- @@ -376,20 +376,6 @@ public void writeSolrDocument(String name,

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-24 Thread michaelbraun
Github user michaelbraun commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190521566 --- Diff: solr/solrj/src/java/org/apache/solr/common/SolrDocument.java --- @@ -388,20 +386,47 @@ public void addChildDocuments(Collection

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-24 Thread moshebla
Github user moshebla commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190477830 --- Diff: solr/solrj/src/java/org/apache/solr/common/SolrDocument.java --- @@ -388,20 +386,47 @@ public void addChildDocuments(Collection children) {

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-23 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190457103 --- Diff: solr/solrj/src/java/org/apache/solr/common/SolrDocument.java --- @@ -388,20 +386,47 @@ public void addChildDocuments(Collection children) {

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-23 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190457184 --- Diff: solr/solrj/src/java/org/apache/solr/common/SolrDocument.java --- @@ -388,20 +386,47 @@ public void addChildDocuments(Collection children) {

[GitHub] lucene-solr pull request #382: WIP: SOLR-12361

2018-05-23 Thread dsmiley
Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/382#discussion_r190386655 --- Diff: solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java --- @@ -376,20 +376,6 @@ public void writeSolrDocument(String name,