[JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 179 - Failure

2013-02-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/Lucene-Solr-NightlyTests-trunk/179/ 3 tests failed. REGRESSION: org.apache.lucene.index.TestIndexWriterOnDiskFull.testAddIndexOnDiskFull Error Message: Stack Trace: java.lang.AssertionError at

Re: [JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 179 - Failure

2013-02-14 Thread Robert Muir
I think this guy cannot assert this in close(), because upon exception we will try to close file handles no matter what state we are in (even if its the middle of a document) On Thu, Feb 14, 2013 at 4:25 AM, Apache Jenkins Server jenk...@builds.apache.org wrote: Build:

Re: [JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 179 - Failure

2013-02-14 Thread Robert Muir
I also think these are redundant with checks in finish(). and finish() could assert that numDocs is equal to the number of times startDocument() was called. On Thu, Feb 14, 2013 at 7:28 AM, Robert Muir rcm...@gmail.com wrote: I think this guy cannot assert this in close(), because upon exception

Re: [JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 179 - Failure

2013-02-14 Thread Shai Erera
Maybe a good idea would be to add asserting message too? Shai On Thu, Feb 14, 2013 at 2:32 PM, Robert Muir rcm...@gmail.com wrote: I also think these are redundant with checks in finish(). and finish() could assert that numDocs is equal to the number of times startDocument() was called.

Re: [JENKINS] Lucene-Solr-NightlyTests-trunk - Build # 179 - Failure

2013-02-14 Thread Robert Muir
I never do this until I'm actually going to debug it. On Thu, Feb 14, 2013 at 7:35 AM, Shai Erera ser...@gmail.com wrote: Maybe a good idea would be to add asserting message too? Shai On Thu, Feb 14, 2013 at 2:32 PM, Robert Muir rcm...@gmail.com wrote: I also think these are redundant