[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083936#comment-14083936
]
Shai Erera edited comment on SOLR-6315 at 8/3/14 10:34 AM:
-----------------------------------------------------------
Simple patch. It's a rote search-and-replace which touches many places in the
code, but the change is really simple. I ran tests and it seems that they
aren't happy with the change though. I think one problem is with
JSONResponseWriter which serializes the response based on the type of
NamedList, and then some tests rely on it. I.e. now that no code creates a
SimpleOrderedList, it never serializes the NamedList as
{{writeNamedListAsMapWithDups()}} ...
So does SimpleOrderedList exists solely for response writing?? If so, we should
document that that's its only purpose, and that e.g. there's nothing "simple"
about it.
But maybe we can fix JSONResponseWriter somehow ... I'll dig there. If anyone
knows this code and have a suggestion, please chime in.
was (Author: shaie):
Simple patch. It's huge because it's a rote search-and-replace, but nothing
special about it. I ran tests and it seems that they aren't happy with the
change though. I think one problem is with JSONResponseWriter which serializes
the response based on the type of NamedList, and then some tests rely on it.
I.e. now that no code creates a SimpleOrderedList, it never serializes the
NamedList as {{writeNamedListAsMapWithDups()}} ...
So does SimpleOrderedList exists solely for response writing?? If so, we should
document that that's its only purpose, and that e.g. there's nothing "simple"
about it.
But maybe we can fix JSONResponseWriter somehow ... I'll dig there. If anyone
knows this code and have a suggestion, please chime in.
> Remove SimpleOrderedMap
> -----------------------
>
> Key: SOLR-6315
> URL: https://issues.apache.org/jira/browse/SOLR-6315
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: SOLR-6315.patch
>
>
> As I described on SOLR-912, SimpleOrderedMap is redundant and generally
> useless class, with confusing jdocs. We should remove it. I'll attach a patch
> shortly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
