[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13090023#comment-13090023
]
Uwe Schindler commented on LUCENE-3218:
---
I would also rename CFIndexInput to
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13090320#comment-13090320
]
Simon Willnauer commented on LUCENE-3218:
-
I committed this to trunk. I will
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089631#comment-13089631
]
Michael McCandless commented on LUCENE-3218:
This approach looks nice! Maybe
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089639#comment-13089639
]
Mark Miller commented on LUCENE-3218:
-
bq. this seems close, the question is if we
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089653#comment-13089653
]
Simon Willnauer commented on LUCENE-3218:
-
I don't really like the name
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089651#comment-13089651
]
Simon Willnauer commented on LUCENE-3218:
-
bq. Why don't we get it committed to
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088640#comment-13088640
]
Simon Willnauer commented on LUCENE-3218:
-
FYI - I backed out the changes from
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088734#comment-13088734
]
Uwe Schindler commented on LUCENE-3218:
---
Showuld we send an email to java-user as
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088796#comment-13088796
]
Simon Willnauer commented on LUCENE-3218:
-
bq. Showuld we send an email to
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088826#comment-13088826
]
Uwe Schindler commented on LUCENE-3218:
---
Hi Simon,
thanks for taking care. This
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088321#comment-13088321
]
Simon Willnauer commented on LUCENE-3218:
-
bq. I think we should back out these
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088335#comment-13088335
]
Uwe Schindler commented on LUCENE-3218:
---
Hi when thinking about the whole stuff one
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088338#comment-13088338
]
Robert Muir commented on LUCENE-3218:
-
None of this is reasonable.
When something
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088344#comment-13088344
]
Uwe Schindler commented on LUCENE-3218:
---
But we can still consider this as
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088359#comment-13088359
]
Michael McCandless commented on LUCENE-3218:
I think both Simon's and Uwe's
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088379#comment-13088379
]
Mark Miller commented on LUCENE-3218:
-
+1 on backing out of 3.x at least - this is
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088392#comment-13088392
]
Simon Willnauer commented on LUCENE-3218:
-
its all yours do whatever you think
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088395#comment-13088395
]
Simon Willnauer commented on LUCENE-3218:
-
bq. None of this is reasonable.
your
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088166#comment-13088166
]
Robert Muir commented on LUCENE-3218:
-
I think the situation here is too complicated
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088206#comment-13088206
]
Michael McCandless commented on LUCENE-3218:
bq. I think we should back out
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087700#comment-13087700
]
Michael McCandless commented on LUCENE-3218:
Maybe we can avoid making a
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087702#comment-13087702
]
Simon Willnauer commented on LUCENE-3218:
-
bq. We did this because previously the
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087704#comment-13087704
]
Marvin Humphrey commented on LUCENE-3218:
-
I don't fully grok Robert's concern,
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087712#comment-13087712
]
Robert Muir commented on LUCENE-3218:
-
This is definitely not a bug in the directory,
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087716#comment-13087716
]
Uwe Schindler commented on LUCENE-3218:
---
Thanks Robert for explaining this again, I
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087719#comment-13087719
]
Robert Muir commented on LUCENE-3218:
-
{quote}
Maybe we can avoid making a separate
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087723#comment-13087723
]
Uwe Schindler commented on LUCENE-3218:
---
bq. i think we should prevent the seek if
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087724#comment-13087724
]
Robert Muir commented on LUCENE-3218:
-
Right, the fix I applied is really a hack, but
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087760#comment-13087760
]
Michael McCandless commented on LUCENE-3218:
{quote}
Why not put that file
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087963#comment-13087963
]
Andrzej Bialecki commented on LUCENE-3218:
---
bq. I think append-only
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087972#comment-13087972
]
Uwe Schindler commented on LUCENE-3218:
---
The trick with the latest updates to
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087987#comment-13087987
]
Simon Willnauer commented on LUCENE-3218:
-
personally I think we should try to be
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087993#comment-13087993
]
Robert Muir commented on LUCENE-3218:
-
I disagree, we don't need to compensate for
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087998#comment-13087998
]
Uwe Schindler commented on LUCENE-3218:
---
If we want append only, we should also
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088005#comment-13088005
]
Robert Muir commented on LUCENE-3218:
-
{quote}
So eventually this is about creating
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13088067#comment-13088067
]
Uwe Schindler commented on LUCENE-3218:
---
When looking into the
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086896#comment-13086896
]
Robert Muir commented on LUCENE-3218:
-
Can CFS reading/writing not take a parent
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053181#comment-13053181
]
Robert Muir commented on LUCENE-3218:
-
Thanks Simon, I feel better now that we get
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052597#comment-13052597
]
Michael McCandless commented on LUCENE-3218:
Patch looks great!
Can we name
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052633#comment-13052633
]
Simon Willnauer commented on LUCENE-3218:
-
Committed in revision 1138063.
I will
[
https://issues.apache.org/jira/browse/LUCENE-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1305#comment-1305
]
Michael McCandless commented on LUCENE-3218:
Patch looks cool!
So the CFW
41 matches
Mail list logo
