[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054397#comment-13054397 ] Michael McCandless commented on LUCENE-3226: Patch looks good -- I like how

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054411#comment-13054411 ] Robert Muir commented on LUCENE-3226: - +1 rename SegmentInfos.FORMAT_3_1 and

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054413#comment-13054413 ] Robert Muir commented on LUCENE-3226: - lets backport this to 3.3? a few issues have

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053784#comment-13053784 ] Michael McCandless commented on LUCENE-3226: Can we have the constant name be

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053814#comment-13053814 ] Michael McCandless commented on LUCENE-3226: bq. What is the benefit of

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053830#comment-13053830 ] Shai Erera commented on LUCENE-3226: bq. I would be OK with just having comments that

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-23 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053859#comment-13053859 ] Michael McCandless commented on LUCENE-3226: OK I agree, I think :) Who will

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053115#comment-13053115 ] Robert Muir commented on LUCENE-3226: - {quote} Also, in LUCENE-2921 I plan to get rid

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053123#comment-13053123 ] Shai Erera commented on LUCENE-3226: How does renaming a constant solve the

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053237#comment-13053237 ] Shai Erera commented on LUCENE-3226: how about printing the oldest and newest segment

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053241#comment-13053241 ] Robert Muir commented on LUCENE-3226: - This would be good (as we can compute it from

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053248#comment-13053248 ] Shai Erera commented on LUCENE-3226: We can print pre-3.1. But, if somebody opened a

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052931#comment-13052931 ] Robert Muir commented on LUCENE-3226: - I'd like to commit this if nobody objects, its

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-21 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052950#comment-13052950 ] Hoss Man commented on LUCENE-3226: -- looks good to me. strictly speaking when

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052954#comment-13052954 ] Robert Muir commented on LUCENE-3226: - bq. strictly speaking when backporting we

[jira] [Commented] (LUCENE-3226) rename SegmentInfos.FORMAT_3_1 and improve description in CheckIndex

2011-06-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053016#comment-13053016 ] Shai Erera commented on LUCENE-3226: bq. I'd like to commit this if nobody objects,