[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059823#comment-13059823
]
Michael McCandless commented on LUCENE-3273:
Thanks Chris! Patch looks great
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059642#comment-13059642
]
Chris Male commented on LUCENE-3273:
In defence of builders, its a great design patte
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059579#comment-13059579
]
Robert Muir commented on LUCENE-3273:
-
after reviewing the core tests, I think there
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059576#comment-13059576
]
Hoss Man commented on LUCENE-3273:
--
bq. In general I'm not a fan of builder APIs... I th
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059538#comment-13059538
]
Michael McCandless commented on LUCENE-3273:
I would also prefer to keep test
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059537#comment-13059537
]
Robert Muir commented on LUCENE-3273:
-
the difference here, is that I think in genera
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059533#comment-13059533
]
Hoss Man commented on LUCENE-3273:
--
to each his own i guess.
I just think it makes sens
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059532#comment-13059532
]
Robert Muir commented on LUCENE-3273:
-
With all due respect hoss, i'd rather have the
[
https://issues.apache.org/jira/browse/LUCENE-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059531#comment-13059531
]
Hoss Man commented on LUCENE-3273:
--
I'm in favor of eliminating the QueryParser dependen
