[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149541#comment-13149541
]
Simon Willnauer commented on LUCENE-3396:
-
chris, this seems to be done no? can
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114136#comment-13114136
]
Chris Male commented on LUCENE-3396:
I haven't actually committed yet. I was hoping
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114149#comment-13114149
]
Robert Muir commented on LUCENE-3396:
-
+1!
Make TokenStream Reuse Mandatory for
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114151#comment-13114151
]
Chris Male commented on LUCENE-3396:
Committed revision 1175297.
I don't want to
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113124#comment-13113124
]
Chris Male commented on LUCENE-3396:
Plan to commit this tomorrow.
Make TokenStream
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102508#comment-13102508
]
Chris Male commented on LUCENE-3396:
Committed revision 1169654.
Make TokenStream
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102443#comment-13102443
]
Chris Male commented on LUCENE-3396:
Committed revision 1169607.
Now attacking the
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098045#comment-13098045
]
Chris Male commented on LUCENE-3396:
I'm going to commit this soon and then work on
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098057#comment-13098057
]
Robert Muir commented on LUCENE-3396:
-
patch looks great: one question, should we
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13098580#comment-13098580
]
Chris Male commented on LUCENE-3396:
Hmmm, I agree that we should change it to void.
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097069#comment-13097069
]
Simon Willnauer commented on LUCENE-3396:
-
this patch looks good to me! I like
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097072#comment-13097072
]
Uwe Schindler commented on LUCENE-3396:
---
Hi, the ReuseStrategies look fine. I am
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097076#comment-13097076
]
Chris Male commented on LUCENE-3396:
Hi Uwe,
I originally had ReuseStrategy with a
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097083#comment-13097083
]
Uwe Schindler commented on LUCENE-3396:
---
I agree its somehow overkill. But if not
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091818#comment-13091818
]
Robert Muir commented on LUCENE-3396:
-
just a quick glance: the MockAnalyzer needs to
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089394#comment-13089394
]
Robert Muir commented on LUCENE-3396:
-
can we create a separate sub-tasks to fix the
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089396#comment-13089396
]
Chris Male commented on LUCENE-3396:
Do you mean correcting the TokenStreams in tests
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089414#comment-13089414
]
Robert Muir commented on LUCENE-3396:
-
yeah: just thinking it could be a nice
[
https://issues.apache.org/jira/browse/LUCENE-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13089417#comment-13089417
]
Chris Male commented on LUCENE-3396:
Done. LUCENE-3397
Make TokenStream Reuse
19 matches
Mail list logo